forgejo/runner
31
87
Fork 91
Code Issues 38 Pull requests 9 Releases 81 Packages 1 Activity Actions

fix: PATH modifications are lost in LXC executions #1326

Merged
mfenniak merged 3 commits from mfenniak/forgejo-runner:fix-lxc-PATH-regression into main 2026-01-23 19:03:17 +00:00
Conversation 3 Commits 3 Files changed 2 +15 -2
mfenniak commented 2026-01-23 18:09:31 +00:00
Owner
Copy link

Regression in #1287 -- --preserve-env=PATH was removed from the sudo command thoughtlessly, where this is required as sudo rewrites this env variable if not explicitly whitelisted.

Incorrect error output "unexpected error handling command output: %!w(*fs.PathError=&{read /dev/ptmx 5})" is also suppressed in this PR, which was added in #1287 but not correctly identified as still a typical exit path for the io.Copy loop.

Fixes #1324

  • bug fixes
    • PR: fix: PATH modifications are lost in LXC executions
Regression in https://code.forgejo.org/forgejo/runner/pulls/1287 -- `--preserve-env=PATH` was removed from the `sudo` command thoughtlessly, where this is required as `sudo` rewrites this env variable if not explicitly whitelisted. Incorrect error output "unexpected error handling command output: %!w(*fs.PathError=&{read /dev/ptmx 5})" is also suppressed in this PR, which was added in #1287 but not correctly identified as still a typical exit path for the `io.Copy` loop. Fixes #1324 <!--start release-notes-assistant--> <!--URL:https://code.forgejo.org/forgejo/runner--> - bug fixes - [PR](https://code.forgejo.org/forgejo/runner/pulls/1326): <!--number 1326 --><!--line 0 --><!--description Zml4OiBgUEFUSGAgbW9kaWZpY2F0aW9ucyBhcmUgbG9zdCBpbiBMWEMgZXhlY3V0aW9ucw==-->fix: `PATH` modifications are lost in LXC executions<!--description--> <!--end release-notes-assistant-->
mfenniak force-pushed fix-lxc-PATH-regression from a974bc3c26
Some checks failed
issue-labels / release-notes (pull_request_target) Successful in 5s
Details
checks / Build Forgejo Runner (pull_request) Failing after 54s
Details
checks / validate pre-commit-hooks file (pull_request) Successful in 57s
Details
checks / runner exec tests (pull_request) Has been skipped
Details
checks / Build unsupported platforms (pull_request) Has been skipped
Details
checks / integration tests (docker-latest) (pull_request) Has been skipped
Details
checks / integration tests (docker-stable) (pull_request) Has been skipped
Details
checks / validate mocks (pull_request) Successful in 1m3s
Details
/ example-docker-compose (pull_request) Successful in 2m11s
Details
/ example-lxc-systemd (pull_request) Has been cancelled
Details
to da15db8ef3
All checks were successful
checks / validate mocks (pull_request) Successful in 42s
Details
checks / validate pre-commit-hooks file (pull_request) Successful in 47s
Details
checks / Build Forgejo Runner (pull_request) Successful in 50s
Details
checks / runner exec tests (pull_request) Successful in 1m3s
Details
/ example-docker-compose (pull_request) Successful in 2m35s
Details
checks / Build unsupported platforms (pull_request) Successful in 1m57s
Details
/ example-lxc-systemd (pull_request) Successful in 8m25s
Details
checks / integration tests (docker-stable) (pull_request) Successful in 14m28s
Details
checks / integration tests (docker-latest) (pull_request) Successful in 11m50s
Details
issue-labels / release-notes (pull_request_target) Successful in 4s
Details
cascade / debug (pull_request_target) Has been skipped
Details
cascade / end-to-end (pull_request_target) Successful in 6s
Details
cascade / forgejo (pull_request_target) Successful in 1m19s
Details
2026-01-23 18:11:57 +00:00 Compare
cascading-pr commented 2026-01-23 18:12:38 +00:00
Contributor
Copy link

cascading-pr updated at actions/setup-forgejo#851

cascading-pr updated at https://code.forgejo.org/actions/setup-forgejo/pulls/851
aahlenst approved these changes 2026-01-23 18:45:48 +00:00
mfenniak deleted branch fix-lxc-PATH-regression 2026-01-23 19:03:18 +00:00
viceice approved these changes 2026-01-23 19:39:27 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
aahlenst
viceice
Labels
Clear labels   
FreeBSD

   
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Chore

It is no fun but it needs to be done, this is a chore.

  
Kind/DependencyUpdate

for pull requests that are created by renovate when updating a dependency

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
Windows

Windows ports is an independent project, see https://github.com/Crown0815/Forgejo-runner-windows-builder

  
linux-powerpc64le

powerpc64le

  
linux-riscv64

   
linux-s390x

   
run-end-to-end-tests

Run https://code.forgejo.org/forgejo/end-to-end with a runner compiled from this pull request

  
run-forgejo-tests

Run https://codeberg.org/forgejo/forgejo tests importing the runner from this pull request

No labels
FreeBSD
Kind/Breaking
Kind/Bug
Kind/Chore
Kind/DependencyUpdate
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Windows
linux-powerpc64le
linux-riscv64
linux-s390x
run-end-to-end-tests
run-forgejo-tests
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
forgejo/runner!1326
No description provided.