forgejo/runner
31
87
Fork 91
Code Issues 38 Pull requests 10 Releases 81 Packages 1 Activity Actions

fix: support "container.network: host" when using job services #1318

Merged
mfenniak merged 1 commit from mfenniak/forgejo-runner:fix-networkmodehost-services into main 2026-01-22 21:58:25 +00:00
Conversation 1 Commits 1 Files changed 4 +34 -3
mfenniak commented 2026-01-22 21:30:17 +00:00
Owner
Copy link

Code archaeology here suggests that when services were first added to act, the intent was to force a randomly named isolated network when services were present. Despite that intent, in runner v8.1.0 it was permitted to allow host networking to work when services were present. This regressed in 8a8e01522d and currently neither behaviour works: a random network name is generated but not the network won't be created, causing an error in this configuration.

This PR fixes the regression and adds a test verifying host networking and services can be used together. This configuration is in-use in the wild. Fixes #1310.

  • bug fixes
    • PR: fix: support "container.network: host" when using job services
Code archaeology here suggests that when services were first added to `act`, the intent was to force a randomly named isolated network when services were present. Despite that intent, in runner v8.1.0 it was permitted to allow host networking to work when services were present. This regressed in 8a8e01522d249399992a29cd4ecb9594cd69d416 and currently neither behaviour works: a random network name is generated but not the network won't be created, causing an error in this configuration. This PR fixes the regression and adds a test verifying host networking and services can be used together. This configuration is in-use in the wild. Fixes #1310. <!--start release-notes-assistant--> <!--URL:https://code.forgejo.org/forgejo/runner--> - bug fixes - [PR](https://code.forgejo.org/forgejo/runner/pulls/1318): <!--number 1318 --><!--line 0 --><!--description Zml4OiBzdXBwb3J0ICJjb250YWluZXIubmV0d29yazogaG9zdCIgd2hlbiB1c2luZyBqb2Igc2VydmljZXM=-->fix: support "container.network: host" when using job services<!--description--> <!--end release-notes-assistant-->
fix: support ContainerNetworkMode: host when using job services
All checks were successful
checks / validate pre-commit-hooks file (pull_request) Successful in 42s
Details
checks / validate mocks (pull_request) Successful in 46s
Details
checks / Build Forgejo Runner (pull_request) Successful in 49s
Details
checks / runner exec tests (pull_request) Successful in 38s
Details
checks / Build unsupported platforms (pull_request) Successful in 1m2s
Details
issue-labels / release-notes (pull_request_target) Successful in 6s
Details
checks / integration tests (docker-latest) (pull_request) Successful in 10m16s
Details
checks / integration tests (docker-stable) (pull_request) Successful in 13m22s
Details
cascade / debug (pull_request_target) Has been skipped
Details
cascade / end-to-end (pull_request_target) Successful in 6s
Details
cascade / forgejo (pull_request_target) Successful in 1m18s
Details
96e0416e96
viceice approved these changes 2026-01-22 21:39:40 +00:00
mfenniak deleted branch fix-networkmodehost-services 2026-01-22 21:58:27 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
viceice
Labels
Clear labels   
FreeBSD

   
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Chore

It is no fun but it needs to be done, this is a chore.

  
Kind/DependencyUpdate

for pull requests that are created by renovate when updating a dependency

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
Windows

Windows ports is an independent project, see https://github.com/Crown0815/Forgejo-runner-windows-builder

  
linux-powerpc64le

powerpc64le

  
linux-riscv64

   
linux-s390x

   
run-end-to-end-tests

Run https://code.forgejo.org/forgejo/end-to-end with a runner compiled from this pull request

  
run-forgejo-tests

Run https://codeberg.org/forgejo/forgejo tests importing the runner from this pull request

No labels
FreeBSD
Kind/Breaking
Kind/Bug
Kind/Chore
Kind/DependencyUpdate
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Windows
linux-powerpc64le
linux-riscv64
linux-s390x
run-end-to-end-tests
run-forgejo-tests
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
forgejo/runner!1318
No description provided.