forgejo/runner
31
87
Fork 91
Code Issues 38 Pull requests 9 Releases 81 Packages 1 Activity Actions

fix: revert switch from lxc-attach to nsenter #1317

Merged
mfenniak merged 1 commit from mfenniak/forgejo-runner:revert-nsenter into main 2026-01-28 18:05:49 +00:00
Conversation 2 Commits 1 Files changed 2 +39 -47
mfenniak commented 2026-01-22 17:27:24 +00:00
Owner
Copy link

Replacing lxc-attach with nsenter continues to cause problems, currently #1341, but previously #1326 and #1336.

As we have an upstream fix in https://github.com/lxc/lxc/pull/4633, I don't think I can justify any further effort in fixing the nsenter behaviour. This PR reverts the change and restores the 100 MiB in-memory buffer -- that buffer can & should be removed when 4633 is broadly available.

All tests added in #1326 and #1336 are retained.

  • bug fixes
    • PR: fix: revert switch from lxc-attach to nsenter
Replacing `lxc-attach` with `nsenter` continues to cause problems, currently #1341, but previously #1326 and #1336. As we have an upstream fix in https://github.com/lxc/lxc/pull/4633, I don't think I can justify any further effort in fixing the `nsenter` behaviour. This PR reverts the change and restores the 100 MiB in-memory buffer -- that buffer can & should be removed when 4633 is broadly available. All tests added in #1326 and #1336 are retained. <!--start release-notes-assistant--> <!--URL:https://code.forgejo.org/forgejo/runner--> - bug fixes - [PR](https://code.forgejo.org/forgejo/runner/pulls/1317): <!--number 1317 --><!--line 0 --><!--description Zml4OiByZXZlcnQgc3dpdGNoIGZyb20gbHhjLWF0dGFjaCB0byBuc2VudGVy-->fix: revert switch from lxc-attach to nsenter<!--description--> <!--end release-notes-assistant-->
mfenniak force-pushed revert-nsenter from 8778e043fb to 81ebffdce4
All checks were successful
issue-labels / release-notes (pull_request_target) Successful in 4s
Details
2026-01-28 17:07:01 +00:00 Compare
mfenniak changed title from WIP: Revert using nsenter rather than lxc-attach [skip ci] to fix: revert switch from lxc-attach to nsenter 2026-01-28 17:13:49 +00:00
mfenniak force-pushed revert-nsenter from 81ebffdce4
All checks were successful
issue-labels / release-notes (pull_request_target) Successful in 4s
Details
to f05f6acfff
All checks were successful
checks / validate pre-commit-hooks file (pull_request) Successful in 37s
Details
checks / validate mocks (pull_request) Successful in 42s
Details
checks / Build Forgejo Runner (pull_request) Successful in 43s
Details
checks / runner exec tests (pull_request) Successful in 43s
Details
checks / Build unsupported platforms (pull_request) Successful in 56s
Details
checks / integration tests (docker-latest) (pull_request) Successful in 9m12s
Details
checks / integration tests (docker-stable) (pull_request) Successful in 9m8s
Details
cascade / forgejo (pull_request_target) Has been skipped
Details
cascade / end-to-end (pull_request_target) Has been skipped
Details
cascade / debug (pull_request_target) Has been skipped
Details
issue-labels / release-notes (pull_request_target) Successful in 8s
Details
2026-01-28 17:14:53 +00:00 Compare
aahlenst approved these changes 2026-01-28 17:15:56 +00:00
aahlenst left a comment
Member
Copy link

Thank you for your efforts.

Thank you for your efforts.
cascading-pr commented 2026-01-28 17:38:17 +00:00
Contributor
Copy link

cascading-pr updated at actions/setup-forgejo#866

cascading-pr updated at https://code.forgejo.org/actions/setup-forgejo/pulls/866
mfenniak deleted branch revert-nsenter 2026-01-28 18:05:49 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
aahlenst
Labels
Clear labels   
FreeBSD

   
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Chore

It is no fun but it needs to be done, this is a chore.

  
Kind/DependencyUpdate

for pull requests that are created by renovate when updating a dependency

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
Windows

Windows ports is an independent project, see https://github.com/Crown0815/Forgejo-runner-windows-builder

  
linux-powerpc64le

powerpc64le

  
linux-riscv64

   
linux-s390x

   
run-end-to-end-tests

Run https://code.forgejo.org/forgejo/end-to-end with a runner compiled from this pull request

  
run-forgejo-tests

Run https://codeberg.org/forgejo/forgejo tests importing the runner from this pull request

No labels
FreeBSD
Kind/Breaking
Kind/Bug
Kind/Chore
Kind/DependencyUpdate
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Windows
linux-powerpc64le
linux-riscv64
linux-s390x
run-end-to-end-tests
run-forgejo-tests
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
forgejo/runner!1317
No description provided.