forgejo/runner
31
87
Fork 91
Code Issues 38 Pull requests 9 Releases 81 Packages 1 Activity Actions

fix: support Forgejo returning AdditionalTasks but not Task #1303

Merged
mfenniak merged 1 commit from mfenniak/forgejo-runner:fix-Forgejo-AdditionalTasks-only into main 2026-01-17 18:51:13 +00:00
Conversation 3 Commits 1 Files changed 2 +18 -5
mfenniak commented 2026-01-17 18:03:26 +00:00
Owner
Copy link

Possible bug that could cause #1302: Forgejo may not be trusted to only return AdditionalTasks when Task is present; so don't drop those jobs if they arrive at the runner.

  • bug fixes
    • PR: fix: support Forgejo returning AdditionalTasks but not Task
Possible bug that could cause https://code.forgejo.org/forgejo/runner/issues/1302: Forgejo may not be trusted to only return `AdditionalTasks` when `Task` is present; so don't drop those jobs if they arrive at the runner. <!--start release-notes-assistant--> <!--URL:https://code.forgejo.org/forgejo/runner--> - bug fixes - [PR](https://code.forgejo.org/forgejo/runner/pulls/1303): <!--number 1303 --><!--line 0 --><!--description Zml4OiBzdXBwb3J0IEZvcmdlam8gcmV0dXJuaW5nIEFkZGl0aW9uYWxUYXNrcyBidXQgbm90IFRhc2s=-->fix: support Forgejo returning AdditionalTasks but not Task<!--description--> <!--end release-notes-assistant-->
viceice approved these changes 2026-01-17 18:37:49 +00:00
Dismissed
aahlenst approved these changes 2026-01-17 18:42:22 +00:00
internal/app/poll/poller.go Outdated
@ -177,0 +177,4 @@
if resp.Msg.Task != nil {
taskSlice = append(taskSlice, resp.Msg.Task)
}
taskSlice = append(taskSlice, resp.Msg.GetAdditionalTasks()...)
aahlenst commented 2026-01-17 18:42:19 +00:00
Member
Copy link

Explaining that might be a good idea so that nobody optimizes it away. Can happen in a future PR.

Explaining that might be a good idea so that nobody optimizes it away. Can happen in a future PR.
mfenniak commented 2026-01-17 18:47:00 +00:00
Author
Owner
Copy link

👍

👍
mfenniak force-pushed fix-Forgejo-AdditionalTasks-only from e21169e4b3
All checks were successful
issue-labels / release-notes (pull_request_target) Successful in 6s
Details
checks / validate pre-commit-hooks file (pull_request) Successful in 1m7s
Details
checks / validate mocks (pull_request) Successful in 1m17s
Details
checks / Build Forgejo Runner (pull_request) Successful in 1m22s
Details
checks / runner exec tests (pull_request) Successful in 41s
Details
checks / Build unsupported platforms (pull_request) Successful in 1m43s
Details
checks / integration tests (docker-latest) (pull_request) Successful in 10m24s
Details
checks / integration tests (docker-stable) (pull_request) Successful in 12m15s
Details
to 00f89f15c1
Some checks failed
cascade / end-to-end (pull_request_target) Has been skipped
Details
cascade / debug (pull_request_target) Has been skipped
Details
cascade / forgejo (pull_request_target) Has been skipped
Details
issue-labels / release-notes (pull_request_target) Successful in 8s
Details
checks / Build Forgejo Runner (pull_request) Successful in 49s
Details
checks / validate pre-commit-hooks file (pull_request) Successful in 51s
Details
checks / validate mocks (pull_request) Successful in 59s
Details
checks / Build unsupported platforms (pull_request) Successful in 40s
Details
checks / integration tests (docker-latest) (pull_request) Has been cancelled
Details
checks / runner exec tests (pull_request) Has been cancelled
Details
checks / integration tests (docker-stable) (pull_request) Has been cancelled
Details
2026-01-17 18:45:12 +00:00 Compare
mfenniak force-pushed fix-Forgejo-AdditionalTasks-only from 00f89f15c1
Some checks failed
cascade / end-to-end (pull_request_target) Has been skipped
Details
cascade / debug (pull_request_target) Has been skipped
Details
cascade / forgejo (pull_request_target) Has been skipped
Details
issue-labels / release-notes (pull_request_target) Successful in 8s
Details
checks / Build Forgejo Runner (pull_request) Successful in 49s
Details
checks / validate pre-commit-hooks file (pull_request) Successful in 51s
Details
checks / validate mocks (pull_request) Successful in 59s
Details
checks / Build unsupported platforms (pull_request) Successful in 40s
Details
checks / integration tests (docker-latest) (pull_request) Has been cancelled
Details
checks / runner exec tests (pull_request) Has been cancelled
Details
checks / integration tests (docker-stable) (pull_request) Has been cancelled
Details
to a08def260d
Some checks failed
issue-labels / release-notes (pull_request_target) Successful in 11s
Details
checks / validate pre-commit-hooks file (pull_request) Successful in 54s
Details
checks / Build Forgejo Runner (pull_request) Successful in 55s
Details
checks / validate mocks (pull_request) Successful in 1m0s
Details
checks / runner exec tests (pull_request) Successful in 52s
Details
checks / Build unsupported platforms (pull_request) Successful in 52s
Details
cascade / debug (pull_request_target) Has been skipped
Details
cascade / end-to-end (pull_request_target) Successful in 7s
Details
cascade / forgejo (pull_request_target) Successful in 27s
Details
checks / integration tests (docker-stable) (pull_request) Failing after 16m54s
Details
checks / integration tests (docker-latest) (pull_request) Successful in 10m56s
Details
2026-01-17 18:46:51 +00:00 Compare
viceice approved these changes 2026-01-17 18:49:19 +00:00
mfenniak deleted branch fix-Forgejo-AdditionalTasks-only 2026-01-17 18:51:14 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
aahlenst
viceice
Labels
Clear labels   
FreeBSD

   
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Chore

It is no fun but it needs to be done, this is a chore.

  
Kind/DependencyUpdate

for pull requests that are created by renovate when updating a dependency

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
Windows

Windows ports is an independent project, see https://github.com/Crown0815/Forgejo-runner-windows-builder

  
linux-powerpc64le

powerpc64le

  
linux-riscv64

   
linux-s390x

   
run-end-to-end-tests

Run https://code.forgejo.org/forgejo/end-to-end with a runner compiled from this pull request

  
run-forgejo-tests

Run https://codeberg.org/forgejo/forgejo tests importing the runner from this pull request

No labels
FreeBSD
Kind/Breaking
Kind/Bug
Kind/Chore
Kind/DependencyUpdate
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Windows
linux-powerpc64le
linux-riscv64
linux-s390x
run-end-to-end-tests
run-forgejo-tests
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
forgejo/runner!1303
No description provided.