test: ping hostname instead of localhost #1284

Merged

viceice merged 2 commits from test/ipv6 into main 2026-01-13 12:56:00 +00:00

Conversation 5 Commits 2 Files changed 1 +1 -1

viceice commented 2026-01-13 09:34:11 +00:00

Owner

Copy link

docker v26 always enables ipv6 on loopback

• https://github.com/moby/moby/releases/tag/v26.0.0

extracted from #1150

• other
  • PR: test: ping hostname instead of localhost

docker v26 always enables ipv6 on loopback - https://github.com/moby/moby/releases/tag/v26.0.0 extracted from #1150 <!--start release-notes-assistant--> <!--URL:https://code.forgejo.org/forgejo/runner--> - other - [PR](https://code.forgejo.org/forgejo/runner/pulls/1284): <!--number 1284 --><!--line 0 --><!--description dGVzdDogcGluZyBob3N0bmFtZSBpbnN0ZWFkIG9mIGxvY2FsaG9zdA==-->test: ping hostname instead of localhost<!--description--> <!--end release-notes-assistant-->

viceice added 1 commit 2026-01-13 09:34:11 +00:00

test: ping hostname instad of localhost ... f9d379520c

docker v26 always enables ipv6 on loopback
- https://github.com/moby/moby/releases/tag/v26.0.0

viceice requested reviews from mfenniak, aahlenst 2026-01-13 09:34:37 +00:00

viceice changed title from test: ping hostname instad of localhost to test: ping hostname instead of localhost 2026-01-13 09:35:07 +00:00

viceice added the

Kind/Testing

label 2026-01-13 09:39:43 +00:00

viceice scheduled this pull request to auto merge when all checks succeed 2026-01-13 10:29:54 +00:00

aahlenst commented 2026-01-13 11:38:30 +00:00

Member

Copy link

What's the benefit of this change?

There should probably be quotes around $(cat /etc/hostname). Just to be on the safe side.

What's the benefit of this change? There should probably be quotes around `$(cat /etc/hostname)`. Just to be on the safe side.

viceice commented 2026-01-13 12:29:10 +00:00

Author

Owner

Copy link

@aahlenst wrote in #1284 (comment):

What's the benefit of this change?

when upgrading to debian trixy, then we get docker v26 instead of v20 and because the host is ipv6 capable docker will enable ipv6 on the loopback device, so this test fails. see older builds of #1150

There should probably be quotes around $(cat /etc/hostname). Just to be on the safe side.

Will add quotes at 0f0fccc020

@aahlenst wrote in https://code.forgejo.org/forgejo/runner/pulls/1284#issuecomment-73076: > What's the benefit of this change? when upgrading to debian trixy, then we get docker v26 instead of v20 and because the host is ipv6 capable docker will enable ipv6 on the loopback device, so this test fails. see older builds of #1150 > There should probably be quotes around `$(cat /etc/hostname)`. Just to be on the safe side. Will add quotes at 0f0fccc02024a668d78d4f3bc2b18c7148369f66

viceice added 1 commit 2026-01-13 12:29:37 +00:00

test; add quotes ... 0f0fccc020

Signed-off-by: viceice <[email protected]>

aahlenst commented 2026-01-13 12:38:30 +00:00

Member

Copy link

@viceice wrote in #1284 (comment):

when upgrading to debian trixy, then we get docker v26 instead of v20 and because the host is ipv6 capable docker will enable ipv6 on the loopback device, so this test fails. see older builds of #1150

I took me some time to connect the dots. It's about testing the --enable-ipv6 switch which isn't possible if Docker does its own thing.

@viceice wrote in https://code.forgejo.org/forgejo/runner/pulls/1284#issuecomment-73100: > when upgrading to debian trixy, then we get docker v26 instead of v20 and because the host is ipv6 capable docker will enable ipv6 on the loopback device, so this test fails. see older builds of #1150 I took me some time to connect the dots. It's about testing the `--enable-ipv6` switch which isn't possible if Docker does its own thing.

aahlenst approved these changes 2026-01-13 12:38:38 +00:00

viceice commented 2026-01-13 12:54:05 +00:00

Author

Owner

Copy link

@aahlenst wrote in #1284 (comment):

@viceice wrote in #1284 (comment):

when upgrading to debian trixy, then we get docker v26 instead of v20 and because the host is ipv6 capable docker will enable ipv6 on the loopback device, so this test fails. see older builds of #1150

I took me some time to connect the dots. It's about testing the --enable-ipv6 switch which isn't possible if Docker does its own thing.

yes. 🤗

@aahlenst wrote in https://code.forgejo.org/forgejo/runner/pulls/1284#issuecomment-73105: > @viceice wrote in #1284 (comment): > > > when upgrading to debian trixy, then we get docker v26 instead of v20 and because the host is ipv6 capable docker will enable ipv6 on the loopback device, so this test fails. see older builds of #1150 > > I took me some time to connect the dots. It's about testing the `--enable-ipv6` switch which isn't possible if Docker does its own thing. yes. 🤗

viceice canceled auto merging this pull request when all checks succeed 2026-01-13 12:54:17 +00:00

viceice scheduled this pull request to auto merge when all checks succeed 2026-01-13 12:54:28 +00:00

viceice merged commit ca8ef5bde2 into main 2026-01-13 12:56:00 +00:00

viceice deleted branch test/ipv6 2026-01-13 12:56:01 +00:00

viceice referenced this pull request from a commit 2026-01-13 12:56:02 +00:00

test: ping hostname instead of localhost (#1284)

viceice-bot referenced this pull request 2026-01-17 20:01:59 +00:00

Update forgejo-runner to v12.5.3 #1305

viceice-bot referenced this pull request from actions/setup-forgejo 2026-01-18 00:10:07 +00:00

Update dependency forgejo/runner to v12.5.3 #838

mfenniak referenced this pull request from a commit 2026-01-18 01:24:16 +00:00

Update dependency forgejo/runner to v12.5.3 (#838)

forgejo-mirror referenced this pull request from a commit 2026-01-18 03:01:31 +00:00

Update module code.forgejo.org/forgejo/runner/v12 to v12.5.3 (forgejo) (#10911)

forgejo-mirror referenced this pull request from a commit 2026-01-23 04:01:23 +00:00

Update module code.forgejo.org/forgejo/runner/v12 to v12.6.0 (v14.0/forgejo) (#11001)

Sign in to join this conversation.

Reviewers

No reviewers

mfenniak

aahlenst

Labels

Clear labels   

FreeBSD

  

Kind/Breaking

Breaking change that won't be backward compatible

  

Kind/Bug

Something is not working

  

Kind/Chore

It is no fun but it needs to be done, this is a chore.

  

Kind/DependencyUpdate

for pull requests that are created by renovate when updating a dependency

  

Kind/Documentation

Documentation changes

  

Kind/Enhancement

Improve existing functionality

  

Kind/Feature

New functionality

  

Kind/Security

This is security issue

  

Kind/Testing

Issue or pull request related to testing

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Reviewed

Confirmed

Issue has been confirmed

  

Reviewed

Duplicate

This issue or pull request already exists

  

Reviewed

Invalid

Invalid issue

  

Reviewed

Won't Fix

This issue won't be fixed

  

Status

Abandoned

Somebody has started to work on this but abandoned work

  

Status

Blocked

Something is blocking this issue or pull request

  

Status

Need More Info

Feedback is required to reproduce issue or to continue work

  

Windows

Windows ports is an independent project, see https://github.com/Crown0815/Forgejo-runner-windows-builder

  

linux-powerpc64le

powerpc64le

  

linux-riscv64

  

linux-s390x

  

run-end-to-end-tests

Run https://code.forgejo.org/forgejo/end-to-end with a runner compiled from this pull request

  

run-forgejo-tests

Run https://codeberg.org/forgejo/forgejo tests importing the runner from this pull request

No labels

FreeBSD

Kind/Breaking

Kind/Bug

Kind/Chore

Kind/DependencyUpdate

Kind/Documentation

Kind/Enhancement

Kind/Feature

Kind/Security

Kind/Testing

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Reviewed

Confirmed

Reviewed

Duplicate

Reviewed

Invalid

Reviewed

Won't Fix

Status

Abandoned

Status

Blocked

Status

Need More Info

Windows

linux-powerpc64le

linux-riscv64

linux-s390x

run-end-to-end-tests

run-forgejo-tests

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

forgejo/runner!1284

No description provided.