feat: introduce experimental command connect with token option #1259
No reviewers
Labels
No labels
FreeBSD
Kind/Breaking
Kind/Bug
Kind/Chore
Kind/DependencyUpdate
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Windows
linux-powerpc64le
linux-riscv64
linux-s390x
run-end-to-end-tests
run-forgejo-tests
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
forgejo/runner!1259
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "aahlenst/runner:connect-command"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Introduce the experimental command
forgejo-runner connect tokenfor connecting Forgejo Runner to a Forgejo instance using the runner token. The runner token can be obtained by registering a new runner using Forgejo's HTTP API. It is required to enable runner management using Forgejo's HTTP API instead of usingforgejo-runner register. That is useful when runner instances are managed by automation or separate applications.Example usage:
The
uuidandtokencan then be passed toforgejo-runner connect token:See forgejo/forgejo-actions-feature-requests#78 for details and design considerations.
Predefined labels in a runner configuration file are currently ignored.
Reviewed, looks good. Pulled down and performed a manual test -- I was a little surprised that the command didn't validate token remotely, but I see that was noted as an open question in your design that was never addressed. I don't consider that a blocker at all; if the behaviour turns out to be desired for any practical reason other than my surprise, it can be added later.
Thanks!