fix: host-based executor, clarify error message from missing working-directory #1257

Merged

mfenniak merged 1 commit from mfenniak/forgejo-runner:upgrade-missing-workdir-to-error into main 2026-01-05 15:24:14 +00:00

Conversation 6 Commits 1 Files changed 1 +4 -2

mfenniak commented 2026-01-05 14:38:58 +00:00

Owner

Copy link

Setting a step to a working directory that doesn't exist causes a debug-level message, typically filtered out by the log level configuration, and then immediately follows with a confusing error. The working directory is the directory that cannot be found, but the error appears as:

 ⚙️ [runner]: RUN fork/exec /usr/bin/sh: no such file or directory

To address this, I've upgraded the debug-level message to an error that stops execution.

This is not a breaking change as it already would have stopped execution.

Fixes #1256.

• bug fixes
  • PR: fix: host-based executor, clarify error message from missing working-directory

Setting a step to a working directory that doesn't exist causes a `debug`-level message, typically filtered out by the log level configuration, and then immediately follows with a confusing error. The working directory is the directory that cannot be found, but the error appears as: ``` ⚙️ [runner]: RUN fork/exec /usr/bin/sh: no such file or directory ``` To address this, I've upgraded the `debug`-level message to an error that stops execution. This is not a breaking change as it already would have stopped execution. Fixes #1256. <!--start release-notes-assistant--> <!--URL:https://code.forgejo.org/forgejo/runner--> - bug fixes - [PR](https://code.forgejo.org/forgejo/runner/pulls/1257): <!--number 1257 --><!--line 0 --><!--description Zml4OiBob3N0LWJhc2VkIGV4ZWN1dG9yLCBjbGFyaWZ5IGVycm9yIG1lc3NhZ2UgZnJvbSBtaXNzaW5nIHdvcmtpbmctZGlyZWN0b3J5-->fix: host-based executor, clarify error message from missing working-directory<!--description--> <!--end release-notes-assistant-->

mfenniak added the

Kind/Bug

label 2026-01-05 14:38:58 +00:00

mfenniak referenced this pull request 2026-01-05 14:39:48 +00:00

bug: No bash/sh in host runner #1256

aahlenst reviewed 2026-01-05 14:46:30 +00:00

aahlenst left a comment

Member

Copy link

Stat() would succeed on a file, but still be invalid. Might make sense to handle that case. As a nice side-effect, it would enable a nicer error message, for example, "working directory is a file" or "working directory does not exist". "failed to stat working directory" is not user-friendly.

`Stat()` would succeed on a file, but still be invalid. Might make sense to handle that case. As a nice side-effect, it would enable a nicer error message, for example, "working directory is a file" or "working directory does not exist". "failed to stat working directory" is not user-friendly.

mfenniak force-pushed upgrade-missing-workdir-to-error from 028ad74992 to 00d01f0989 2026-01-05 14:53:29 +00:00 Compare

mfenniak commented 2026-01-05 14:54:40 +00:00

Author

Owner

Copy link

That's a good call; the error message would otherwise be quite confusing there as well since it still seems associated with the shell:

⚙️ [runner]: RUN fork/exec /usr/bin/sh: not a directory

I've added a !IsDir() check and manually tested it:

⚙️ [runner]: working directory /home/mfenniak/.cache/act/3a5d8a793d4519cf/hostexecutor/workspace is not a directory

That's a good call; the error message would otherwise be quite confusing there as well since it still seems associated with the shell: ``` ⚙️ [runner]: RUN fork/exec /usr/bin/sh: not a directory ``` I've added a `!IsDir()` check and manually tested it: ``` ⚙️ [runner]: working directory /home/mfenniak/.cache/act/3a5d8a793d4519cf/hostexecutor/workspace is not a directory ```

aahlenst approved these changes 2026-01-05 15:04:11 +00:00

aahlenst left a comment

Member

Copy link

Thanks, great!

Thanks, great!

limiting-factor approved these changes 2026-01-05 15:12:51 +00:00

mfenniak merged commit d96978cb8f into main 2026-01-05 15:24:14 +00:00

mfenniak referenced this pull request from a commit 2026-01-05 15:24:14 +00:00

fix: host-based executor, clarify error message from missing working-directory (#1257)

mfenniak deleted branch upgrade-missing-workdir-to-error 2026-01-05 15:24:14 +00:00

viceice approved these changes 2026-01-05 23:14:24 +00:00

viceice commented 2026-01-05 23:14:58 +00:00

Owner

Copy link

a test would have been nice 🙂

a test would have been nice 🙂

viceice-bot referenced this pull request from actions/setup-forgejo 2026-01-09 00:04:51 +00:00

Update dependency forgejo/runner to v12.5.0 #806

mfenniak referenced this pull request from a commit 2026-01-09 01:26:43 +00:00

Update dependency forgejo/runner to v12.5.0 (#806)

forgejo-mirror referenced this pull request from a commit 2026-01-09 02:01:10 +00:00

Update module code.forgejo.org/forgejo/runner/v12 to v12.5.0 (forgejo) (#10738)

viceice-bot referenced this pull request 2026-01-09 09:31:42 +00:00

Update forgejo-runner to v12.5.0 #1263

forgejo-mirror referenced this pull request from a commit 2026-01-23 04:01:24 +00:00

Update module code.forgejo.org/forgejo/runner/v12 to v12.6.0 (v14.0/forgejo) (#11001)

Sign in to join this conversation.

Reviewers

No reviewers

aahlenst

limiting-factor

viceice

Labels

Clear labels   

FreeBSD

  

Kind/Breaking

Breaking change that won't be backward compatible

  

Kind/Bug

Something is not working

  

Kind/Chore

It is no fun but it needs to be done, this is a chore.

  

Kind/DependencyUpdate

for pull requests that are created by renovate when updating a dependency

  

Kind/Documentation

Documentation changes

  

Kind/Enhancement

Improve existing functionality

  

Kind/Feature

New functionality

  

Kind/Security

This is security issue

  

Kind/Testing

Issue or pull request related to testing

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Reviewed

Confirmed

Issue has been confirmed

  

Reviewed

Duplicate

This issue or pull request already exists

  

Reviewed

Invalid

Invalid issue

  

Reviewed

Won't Fix

This issue won't be fixed

  

Status

Abandoned

Somebody has started to work on this but abandoned work

  

Status

Blocked

Something is blocking this issue or pull request

  

Status

Need More Info

Feedback is required to reproduce issue or to continue work

  

Windows

Windows ports is an independent project, see https://github.com/Crown0815/Forgejo-runner-windows-builder

  

linux-powerpc64le

powerpc64le

  

linux-riscv64

  

linux-s390x

  

run-end-to-end-tests

Run https://code.forgejo.org/forgejo/end-to-end with a runner compiled from this pull request

  

run-forgejo-tests

Run https://codeberg.org/forgejo/forgejo tests importing the runner from this pull request

No labels

FreeBSD

Kind/Breaking

Kind/Bug

Kind/Chore

Kind/DependencyUpdate

Kind/Documentation

Kind/Enhancement

Kind/Feature

Kind/Security

Kind/Testing

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Reviewed

Confirmed

Reviewed

Duplicate

Reviewed

Invalid

Reviewed

Won't Fix

Status

Abandoned

Status

Blocked

Status

Need More Info

Windows

linux-powerpc64le

linux-riscv64

linux-s390x

run-end-to-end-tests

run-forgejo-tests

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

4 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

forgejo/runner!1257

No description provided.