fix: re-parsing incomplete jobs must use on.workflow_call.inputs, not global inputs

mfenniak commented

2025-12-31 04:02:04 +00:00

Owner

Defect discovered while testing https://codeberg.org/forgejo/forgejo/pulls/10647 -- within a nested reusable workflow that is also "incomplete" (can't be fully defined until an input from another job is provided), the inputs context is incorrectly evaluated in the context of the top-most workflow, rather than the reusable workflow's inputs.

In other words, when the job layer-2 is defined in this end-to-end test...

forgejo/end-to-end@776506dfef/actions/example-workflow-call-expansion/.forgejo/workflows/reusable-layer-1.yml (L44-L52)

It has to be parsed twice:

the first time it is marked "incomplete" because ${{ needs.callee-1... }} isn't defined, since callee-1 isn't done.
the second time it is parsed, ${{ inputs... }} was incorrectly referencing the overall job's inputs, not the inputs to reusable-layer-1.yml, due to the bug here.

bug fixes
- PR: fix: re-parsing incomplete jobs must use on.workflow_call.inputs, not global inputs

Defect discovered while testing https://codeberg.org/forgejo/forgejo/pulls/10647 -- within a nested reusable workflow that is also "incomplete" (can't be fully defined until an input from another job is provided), the `inputs` context is incorrectly evaluated in the context of the top-most workflow, rather than the reusable workflow's inputs. In other words, when the job `layer-2` is defined in [this end-to-end test](https://code.forgejo.org/forgejo/end-to-end/pulls/1362)... https://code.forgejo.org/forgejo/end-to-end/src/commit/776506dfef1144fd86ffe1252bf25d53ff3b6a53/actions/example-workflow-call-expansion/.forgejo/workflows/reusable-layer-1.yml#L44-L52 It has to be parsed twice: - the first time it is marked "incomplete" because `${{ needs.callee-1... }}` isn't defined, since `callee-1` isn't done. - the second time it is parsed, `${{ inputs... }}` was incorrectly referencing the overall job's inputs, not the inputs to `reusable-layer-1.yml`, due to the bug here.   - bug fixes - [PR](https://code.forgejo.org/forgejo/runner/pulls/1251): fix: re-parsing incomplete jobs must use on.workflow_call.inputs, not global inputs

mfenniak changed title from ~~fix: re-parsing jobs must use on.workflow_call.inputs, not global inputs~~ to fix: re-parsing incomplete jobs must use on.workflow_call.inputs, not global inputs

2025-12-31 04:03:11 +00:00

mfenniak force-pushed workflow-call-reparse-inputs from bb6013a713

checks / build and test (pull_request) Failing after 42s

Details

checks / runner exec tests (pull_request) Has been skipped

Details

checks / runner integration tests (pull_request) Has been skipped

Details

checks / validate pre-commit-hooks file (pull_request) Successful in 44s

Details

checks / validate mocks (pull_request) Failing after 45s

Details