fix: stop creation of branch called HEAD during fetch #1250

Merged

mfenniak merged 1 commit from aahlenst/runner:ambiguous-head into main 2026-01-03 04:25:34 +00:00

Conversation 19 Commits 1 Files changed 2 +63 -1

aahlenst commented 2025-12-30 14:11:13 +00:00

Member

Copy link

When cloning a repository or updating the existing clone, Forgejo Runner performs a fetch. The ref spec HEAD:refs/heads/HEAD motivates go-git to create a local branch called HEAD. Consequently, HEAD becomes ambiguous and git rightfully complains about it (warning: refname 'HEAD' is ambiguous.).

• bug fixes
  • PR: fix: stop creation of branch called HEAD during fetch

When cloning a repository or updating the existing clone, Forgejo Runner performs a fetch. The ref spec `HEAD:refs/heads/HEAD` motivates go-git to create a local branch called `HEAD`. Consequently, `HEAD` becomes ambiguous and `git` rightfully complains about it (`warning: refname 'HEAD' is ambiguous.`). <!--start release-notes-assistant--> <!--URL:https://code.forgejo.org/forgejo/runner--> - bug fixes - [PR](https://code.forgejo.org/forgejo/runner/pulls/1250): <!--number 1250 --><!--line 0 --><!--description Zml4OiBzdG9wIGNyZWF0aW9uIG9mIGJyYW5jaCBjYWxsZWQgSEVBRCBkdXJpbmcgZmV0Y2g=-->fix: stop creation of branch called HEAD during fetch<!--description--> <!--end release-notes-assistant-->

aahlenst force-pushed ambiguous-head from 915b5c0a60 to b28f25256a 2025-12-30 14:11:30 +00:00 Compare

viceice reviewed 2025-12-30 20:30:55 +00:00

viceice left a comment

Owner

Copy link

I think this needs a unit test

I think this needs a unit test

mfenniak approved these changes 2025-12-30 21:54:19 +00:00

mfenniak left a comment

Owner

Copy link

Hm... it's a weird thing to unit test "not doing something that was always wrong". 🤔 I'm OK with merging this without a test because of that, but I'll hold onto it and let @viceice disagree if he's firm on it.

I tracked back when this was added (in act) and there was no rationale or explanation for it... I vaguely think it might have occurred because refs/* is supported by go-git and treats the wildcard as matching a path separator, but git doesn't, so there may not have been an understanding that refs/* actually fetches all remote refs.

Hm... it's a weird thing to unit test "not doing something that was always wrong". 🤔 I'm OK with merging this without a test because of that, but I'll hold onto it and let @viceice disagree if he's firm on it. I tracked back [when this was added](https://github.com/nektos/act/pull/679) (in act) and there was no rationale or explanation for it... I vaguely think it might have occurred because `refs/*` is supported by go-git and treats the wildcard as matching a path separator, but git doesn't, so there may not have been an understanding that `refs/*` actually fetches all remote refs.

viceice commented 2025-12-30 22:09:42 +00:00

Owner

Copy link

I mean we should add a unit test to ensure it'll not break again

I mean we should add a unit test to ensure it'll not break again

aahlenst force-pushed ambiguous-head from b28f25256a to 9b835e0a4a 2026-01-02 10:28:36 +00:00 Compare

limiting-factor commented 2026-01-02 10:53:17 +00:00

Member

Copy link

The test error is environmental and unrelated, it needs a re-run https://code.forgejo.org/forgejo/runner/actions/runs/14190/jobs/2/attempt/1#jobstep-3-19

The test error is environmental and unrelated, it needs a re-run https://code.forgejo.org/forgejo/runner/actions/runs/14190/jobs/2/attempt/1#jobstep-3-19

limiting-factor commented 2026-01-02 10:56:10 +00:00

Member

Copy link

I don't see how that can be tested with certainty: the content of this list can be incorrect in ways that won't trigger an error.

I don't see how that can be tested with certainty: the content of this list can be incorrect in ways that won't trigger an error.

limiting-factor approved these changes 2026-01-02 10:56:23 +00:00

aahlenst force-pushed ambiguous-head from 9b835e0a4a to efe86f5ac3 2026-01-02 11:30:23 +00:00 Compare

aahlenst commented 2026-01-02 11:31:41 +00:00

Author

Member

Copy link

There is now a test: 9b835e0a4a..efe86f5ac3

There is now a test: https://code.forgejo.org/forgejo/runner/compare/9b835e0a4aef302d417f4c0db7ae5c1e626f9c36..efe86f5ac36892d742f0399df9d1fb4d3b9054c2

👍 1 ❤️ 1

viceice approved these changes 2026-01-02 12:14:57 +00:00

viceice left a comment

Owner

Copy link

ci failure seems to be an upstream docker debian apt repo issue 🤔

ci failure seems to be an upstream docker debian apt repo issue 🤔

aahlenst commented 2026-01-02 12:16:48 +00:00

Author

Member

Copy link

@viceice It looks like a DNS resolution or caching problem. I can access the repository.

@viceice It looks like a DNS resolution or caching problem. I can access the repository.

limiting-factor commented 2026-01-02 12:16:53 +00:00

Member

Copy link

The unrelated error is due to LXC caching and persists.

https://code.forgejo.org/forgejo/runner/actions/runs/14194/jobs/2/attempt/2

It will stay until the cache expires. To resolve it immediately the LXC container of this runner can be stopped and restarted. It will discard the cache.

https://code.forgejo.org/forgejo/runner/src/branch/main/examples/lxc-systemd#how-it-works

forgejo/lxc-helpers – lxc-helpers-lib.sh

Line 400 in forgejo/lxc-helpers@5bb6e6d

lxc_container_run $draft apt-get update -qq

The unrelated error is due to LXC caching and persists. https://code.forgejo.org/forgejo/runner/actions/runs/14194/jobs/2/attempt/2 It will stay until the cache expires. To resolve it immediately the LXC container of this runner can be stopped and restarted. It will discard the cache. https://code.forgejo.org/forgejo/runner/src/branch/main/examples/lxc-systemd#how-it-works https://code.forgejo.org/forgejo/lxc-helpers/src/commit/5bb6e6d7b4791a579197cad809e79672462535f9/lxc-helpers-lib.sh#L400

viceice commented 2026-01-02 15:11:11 +00:00

Owner

Copy link

@limiting-factor wrote in #1250 (comment):

The unrelated error is due to LXC caching and persists.

https://code.forgejo.org/forgejo/runner/actions/runs/14194/jobs/2/attempt/2

It will stay until the cache expires. To resolve it immediately the LXC container of this runner can be stopped and restarted. It will discard the cache.

https://code.forgejo.org/forgejo/runner/src/branch/main/examples/lxc-systemd#how-it-works

forgejo/lxc-helpers – lxc-helpers-lib.sh
Line 400 in forgejo/lxc-helpers@5bb6e6d
lxc_container_run $draft apt-get update -qq

will restart it in a few minutes

@limiting-factor wrote in https://code.forgejo.org/forgejo/runner/pulls/1250#issuecomment-71459: > The unrelated error is due to LXC caching and persists. > > https://code.forgejo.org/forgejo/runner/actions/runs/14194/jobs/2/attempt/2 > > It will stay until the cache expires. To resolve it immediately the LXC container of this runner can be stopped and restarted. It will discard the cache. > > https://code.forgejo.org/forgejo/runner/src/branch/main/examples/lxc-systemd#how-it-works > > [forgejo/lxc-helpers](https://code.forgejo.org/forgejo/lxc-helpers/) – [lxc-helpers-lib.sh](https://code.forgejo.org/forgejo/lxc-helpers/src/commit/5bb6e6d7b4791a579197cad809e79672462535f9/lxc-helpers-lib.sh#L400) > Line 400 in [forgejo/lxc-helpers@5bb6e6d](https://code.forgejo.org/forgejo/lxc-helpers/src/commit/5bb6e6d7b4791a579197cad809e79672462535f9) > ` lxc_container_run $draft apt-get update -qq ` will restart it in a few minutes

viceice commented 2026-01-02 15:17:38 +00:00

Owner

Copy link

didn't worked. it seems something between runner and docker repo is broken 🤔

didn't worked. it seems something between runner and docker repo is broken 🤔

viceice commented 2026-01-02 15:22:15 +00:00

Owner

Copy link

.forgejo/install-docker.sh

Lines 16 to 34 in 1a586f3

	# Derived from Docker's official debian installation documentation: https://docs.docker.com/engine/install/debian/#install-using-the-repository
	# Add Docker's official GPG key:
	apt-get update
	apt-get install -y -qq ca-certificates curl
	install -m 0755 -d /etc/apt/keyrings
	curl -fsSL https://download.docker.com/linux/debian/gpg -o /etc/apt/keyrings/docker.asc
	chmod a+r /etc/apt/keyrings/docker.asc
	# Add the repository to Apt sources:
	tee /etc/apt/sources.list.d/docker.sources <<EOF
	Types: deb
	URIs: https://download.docker.com/linux/debian
	Suites: $(. /etc/os-release && echo "$VERSION_CODENAME")
	Components: stable
	Signed-By: /etc/apt/keyrings/docker.asc
	EOF
	apt-get update
	apt-get install -y -qq docker-ce docker-ce-cli containerd.io docker-buildx-plugin docker-compose-plugin

https://code.forgejo.org/forgejo/runner/src/commit/1a586f3dfae1766319aefcf82e0f8bd611e4741a/.forgejo/install-docker.sh#L16-L34

viceice commented 2026-01-02 15:25:15 +00:00

Owner

Copy link

there is no containerd 2.2.1 at https://download.docker.com/linux/debian/dists/bookworm/pool/stable/amd64/

there is no containerd 2.2.1 at https://download.docker.com/linux/debian/dists/bookworm/pool/stable/amd64/

viceice commented 2026-01-02 15:29:22 +00:00

Owner

Copy link

also missing on trixie https://download.docker.com/linux/debian/dists/trixie/pool/stable/amd64/

also missing on trixie https://download.docker.com/linux/debian/dists/trixie/pool/stable/amd64/

viceice commented 2026-01-02 15:32:32 +00:00

Owner

Copy link

https://forums.docker.com/t/installation-issues-on-ubuntu/150736

https://forums.docker.com/t/installation-issues-on-ubuntu/150736

viceice commented 2026-01-02 15:36:47 +00:00

Owner

Copy link

should be back in ~20min

https://github.com/containerd/containerd/issues/12741#issuecomment-3705600052

should be back in ~20min https://github.com/containerd/containerd/issues/12741#issuecomment-3705600052

viceice commented 2026-01-02 16:05:10 +00:00

Owner

Copy link

running 🥳

running 🥳

👍 1 🎉 1

mfenniak added the

run-end-to-end-tests

label 2026-01-03 03:58:16 +00:00

cascading-pr referenced this pull request from actions/setup-forgejo 2026-01-03 03:58:38 +00:00

cascading-pr from https://code.forgejo.org/forgejo/runner refs/pull/1250/head to forgejo/runner-1250 #804

cascading-pr commented 2026-01-03 03:58:39 +00:00

Contributor

Copy link

cascading-pr updated at actions/setup-forgejo#804

cascading-pr updated at https://code.forgejo.org/actions/setup-forgejo/pulls/804

mfenniak merged commit f9109c4f94 into main 2026-01-03 04:25:34 +00:00

mfenniak referenced this pull request from a commit 2026-01-03 04:25:35 +00:00

fix: stop creation of branch called HEAD during fetch (#1250)

viceice-bot referenced this pull request from actions/setup-forgejo 2026-01-09 00:04:51 +00:00

Update dependency forgejo/runner to v12.5.0 #806

mfenniak referenced this pull request from a commit 2026-01-09 01:26:43 +00:00

Update dependency forgejo/runner to v12.5.0 (#806)

forgejo-mirror referenced this pull request from a commit 2026-01-09 02:01:10 +00:00

Update module code.forgejo.org/forgejo/runner/v12 to v12.5.0 (forgejo) (#10738)

viceice-bot referenced this pull request 2026-01-09 09:31:42 +00:00

Update forgejo-runner to v12.5.0 #1263

forgejo-mirror referenced this pull request from a commit 2026-01-23 04:01:24 +00:00

Update module code.forgejo.org/forgejo/runner/v12 to v12.6.0 (v14.0/forgejo) (#11001)

Sign in to join this conversation.

Reviewers

No reviewers

mfenniak

limiting-factor

viceice

Labels

Clear labels   

FreeBSD

  

Kind/Breaking

Breaking change that won't be backward compatible

  

Kind/Bug

Something is not working

  

Kind/Chore

It is no fun but it needs to be done, this is a chore.

  

Kind/DependencyUpdate

for pull requests that are created by renovate when updating a dependency

  

Kind/Documentation

Documentation changes

  

Kind/Enhancement

Improve existing functionality

  

Kind/Feature

New functionality

  

Kind/Security

This is security issue

  

Kind/Testing

Issue or pull request related to testing

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Reviewed

Confirmed

Issue has been confirmed

  

Reviewed

Duplicate

This issue or pull request already exists

  

Reviewed

Invalid

Invalid issue

  

Reviewed

Won't Fix

This issue won't be fixed

  

Status

Abandoned

Somebody has started to work on this but abandoned work

  

Status

Blocked

Something is blocking this issue or pull request

  

Status

Need More Info

Feedback is required to reproduce issue or to continue work

  

Windows

Windows ports is an independent project, see https://github.com/Crown0815/Forgejo-runner-windows-builder

  

linux-powerpc64le

powerpc64le

  

linux-riscv64

  

linux-s390x

  

run-end-to-end-tests

Run https://code.forgejo.org/forgejo/end-to-end with a runner compiled from this pull request

  

run-forgejo-tests

Run https://codeberg.org/forgejo/forgejo tests importing the runner from this pull request

No labels

FreeBSD

Kind/Breaking

Kind/Bug

Kind/Chore

Kind/DependencyUpdate

Kind/Documentation

Kind/Enhancement

Kind/Feature

Kind/Security

Kind/Testing

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Reviewed

Confirmed

Reviewed

Duplicate

Reviewed

Invalid

Reviewed

Won't Fix

Status

Abandoned

Status

Blocked

Status

Need More Info

Windows

linux-powerpc64le

linux-riscv64

linux-s390x

run-end-to-end-tests

run-forgejo-tests

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

5 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

forgejo/runner!1250

No description provided.