feat(jobparser): support ${{ needs... }} in runs-on as IncompleteRunsOn #1194

Merged

mfenniak merged 5 commits from runs-on-references-dynamic-matrix into main 2025-12-01 15:42:16 +00:00

Conversation 4 Commits 5 Files changed 15 +512 -71

mfenniak commented 2025-11-30 04:12:27 +00:00

Owner

Copy link

Note: this PR is stacked on #1195.

Following the same pattern as #1190, this PR adds support for ${{ needs ... }} within the runs-on field. It also extends the support of the runs-on: ${{ matrix... }} to include matrixes that are dynamically defined per #1190.

Minor additional changes are required in Forgejo to: use the new SupportIncompleteRunsOn() parse option, mark jobs as blocked when they come back as IncompleteRunsOn, and add related error handling and test automation cases.

Together these changes allow the accurate parsing of these jobs that aren't supported currently:

on:
  push:

jobs:
  define-matrix:
    runs-on: docker
    outputs:
      scalar-value: ${{ steps.define.outputs.scalar }}
      array-value: ${{ steps.define.outputs.array }}
    steps:
      - id: define
        run: |
          echo 'scalar=debian-ci-latest' >> "$FORGEJO_OUTPUT"
          echo 'array=["debian-latest", "debian-ci-latest"]' >> "$FORGEJO_OUTPUT"

  runs-on-needs:
    needs: define-matrix
    runs-on: ${{ needs.define-matrix.outputs.scalar-value }}
    steps:
      - run: uname -a

  runs-on-dynamic-matrix:
    needs: define-matrix
    strategy:
      matrix:
        runs-on:
          - debian-latest
          - "${{ needs.define-matrix.outputs.scalar-value }}"
    runs-on: ${{ matrix.runs-on }}
    steps:
      - run: uname -a

• features
  • PR: feat(jobparser): support ${{ needs... }} in runs-on as IncompleteRunsOn

**Note:** this PR is stacked on #1195. Following the same pattern as #1190, this PR adds support for `${{ needs ... }}` within the `runs-on` field. It also extends the support of the `runs-on: ${{ matrix... }}` to include matrixes that are dynamically defined per #1190. Minor additional changes are required in Forgejo to: use the new `SupportIncompleteRunsOn()` parse option, mark jobs as blocked when they come back as `IncompleteRunsOn`, and add related error handling and test automation cases. Together these changes allow the accurate parsing of these jobs that aren't supported currently: ```yaml on: push: jobs: define-matrix: runs-on: docker outputs: scalar-value: ${{ steps.define.outputs.scalar }} array-value: ${{ steps.define.outputs.array }} steps: - id: define run: | echo 'scalar=debian-ci-latest' >> "$FORGEJO_OUTPUT" echo 'array=["debian-latest", "debian-ci-latest"]' >> "$FORGEJO_OUTPUT" runs-on-needs: needs: define-matrix runs-on: ${{ needs.define-matrix.outputs.scalar-value }} steps: - run: uname -a runs-on-dynamic-matrix: needs: define-matrix strategy: matrix: runs-on: - debian-latest - "${{ needs.define-matrix.outputs.scalar-value }}" runs-on: ${{ matrix.runs-on }} steps: - run: uname -a ``` <!--start release-notes-assistant--> <!--URL:https://code.forgejo.org/forgejo/runner--> - features - [PR](https://code.forgejo.org/forgejo/runner/pulls/1194): <!--number 1194 --><!--line 0 --><!--description ZmVhdChqb2JwYXJzZXIpOiBzdXBwb3J0ICR7eyBuZWVkcy4uLiB9fSBpbiBydW5zLW9uIGFzIEluY29tcGxldGVSdW5zT24=-->feat(jobparser): support ${{ needs... }} in runs-on as IncompleteRunsOn<!--description--> <!--end release-notes-assistant-->

mfenniak added the

Kind/Enhancement

label 2025-11-30 04:12:27 +00:00

mfenniak added 1 commit 2025-11-30 04:12:27 +00:00

feat(jobparser): enhance incomplete_matrix with information about what job & output was accessed 675d1c949b

mfenniak changed title from feat(jobparser): support ${{ needs... }} in runs-on as IncompleteRunsOn to WIP: feat(jobparser): support ${{ needs... }} in runs-on as IncompleteRunsOn 2025-11-30 04:36:03 +00:00

mfenniak commented 2025-11-30 04:36:29 +00:00

Author

Owner

Copy link

Marked as WIP for the moment due to a test failure in evalmatrixneeds2 that I won't be able to immediately fix.

Marked as WIP for the moment due to a test failure in `evalmatrixneeds2` that I won't be able to immediately fix.

mfenniak referenced this pull request 2025-11-30 17:35:39 +00:00

fix(jobparser): can't access needs via [...] in InvalidJobOutput mode #1195

mfenniak force-pushed runs-on-references-dynamic-matrix from 960c356ee9 to c5703f2c03 2025-11-30 17:46:59 +00:00 Compare

mfenniak force-pushed runs-on-references-dynamic-matrix from c5703f2c03 to 7f13e5cf30 2025-11-30 17:49:18 +00:00 Compare

mfenniak added the

run-end-to-end-tests

run-forgejo-tests

labels 2025-11-30 18:53:33 +00:00

mfenniak changed title from WIP: feat(jobparser): support ${{ needs... }} in runs-on as IncompleteRunsOn to feat(jobparser): support ${{ needs... }} in runs-on as IncompleteRunsOn 2025-11-30 18:53:37 +00:00

cascading-pr referenced this pull request from actions/setup-forgejo 2025-11-30 18:53:49 +00:00

cascading-pr from https://code.forgejo.org/forgejo/runner refs/pull/1194/head to forgejo/runner-1194 #781

cascading-pr commented 2025-11-30 18:53:50 +00:00

Contributor

Copy link

cascading-pr updated at actions/setup-forgejo#781

cascading-pr updated at https://code.forgejo.org/actions/setup-forgejo/pulls/781

cascading-pr commented 2025-11-30 22:09:26 +00:00

Contributor

Copy link

cascading-pr updated at https://codeberg.org/forgejo/forgejo/pulls/10272

cascading-pr updated at https://codeberg.org/forgejo/forgejo/pulls/10272

earl-warren approved these changes 2025-12-01 14:00:42 +00:00

mfenniak merged commit 178c61fb44 into main 2025-12-01 15:42:16 +00:00

mfenniak referenced this pull request from a commit 2025-12-01 15:42:18 +00:00

feat(jobparser): support ${{ needs... }} in runs-on as IncompleteRunsOn (#1194)

mfenniak deleted branch runs-on-references-dynamic-matrix 2025-12-01 15:42:18 +00:00

mfenniak referenced this pull request 2025-12-01 15:42:56 +00:00

fix(jobparser): can't access needs via [...] in InvalidJobOutput mode #1195

viceice-bot referenced this pull request 2025-12-26 20:31:35 +00:00

Update forgejo-runner to v12.3.1 #1242

mfenniak referenced this pull request from a commit 2025-12-26 21:58:58 +00:00

Update forgejo-runner to v12.3.1 (#1242)

viceice-bot referenced this pull request from actions/setup-forgejo 2025-12-27 15:07:34 +00:00

Update dependency forgejo/runner to v12 #800

mfenniak referenced this pull request 2026-01-18 03:03:01 +00:00

fix(jobparser): evaluating matrix values within runs-on references first matrix value only #1307

mfenniak referenced this pull request from a commit 2026-01-18 17:27:11 +00:00

fix(jobparser): evaluating matrix values within runs-on references first matrix value only (#1307)

Sign in to join this conversation.

Reviewers

No reviewers

earl-warren

Labels

Clear labels   

FreeBSD

  

Kind/Breaking

Breaking change that won't be backward compatible

  

Kind/Bug

Something is not working

  

Kind/Chore

It is no fun but it needs to be done, this is a chore.

  

Kind/DependencyUpdate

for pull requests that are created by renovate when updating a dependency

  

Kind/Documentation

Documentation changes

  

Kind/Enhancement

Improve existing functionality

  

Kind/Feature

New functionality

  

Kind/Security

This is security issue

  

Kind/Testing

Issue or pull request related to testing

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Reviewed

Confirmed

Issue has been confirmed

  

Reviewed

Duplicate

This issue or pull request already exists

  

Reviewed

Invalid

Invalid issue

  

Reviewed

Won't Fix

This issue won't be fixed

  

Status

Abandoned

Somebody has started to work on this but abandoned work

  

Status

Blocked

Something is blocking this issue or pull request

  

Status

Need More Info

Feedback is required to reproduce issue or to continue work

  

Windows

Windows ports is an independent project, see https://github.com/Crown0815/Forgejo-runner-windows-builder

  

linux-powerpc64le

powerpc64le

  

linux-riscv64

  

linux-s390x

  

run-end-to-end-tests

Run https://code.forgejo.org/forgejo/end-to-end with a runner compiled from this pull request

  

run-forgejo-tests

Run https://codeberg.org/forgejo/forgejo tests importing the runner from this pull request

No labels

FreeBSD

Kind/Breaking

Kind/Bug

Kind/Chore

Kind/DependencyUpdate

Kind/Documentation

Kind/Enhancement

Kind/Feature

Kind/Security

Kind/Testing

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Reviewed

Confirmed

Reviewed

Duplicate

Reviewed

Invalid

Reviewed

Won't Fix

Status

Abandoned

Status

Blocked

Status

Need More Info

Windows

linux-powerpc64le

linux-riscv64

linux-s390x

run-end-to-end-tests

run-forgejo-tests

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

3 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

forgejo/runner!1194

No description provided.