forgejo/act
Archived
24
5
Fork 16
Code Issues Pull requests Releases Activity Actions

feat: --hostname is allowed in container options #95

Merged
earl-warren merged 1 commit from earl-warren/act:wip-option-hostname into main 2025-01-22 18:22:29 +00:00
Conversation 7 Commits 1 Files changed 2 +8 -2
earl-warren commented 2025-01-22 16:47:16 +00:00
Contributor
Copy link

It is useful to set an alternative hostname when running a service
such as:

services:
  minio:
    image: data.forgejo.org/oci/bitnami/minio:2024.8.17
    options: >-
      --hostname alternate.minio
It is useful to set an alternative hostname when running a service such as: ```yaml services: minio: image: data.forgejo.org/oci/bitnami/minio:2024.8.17 options: >- --hostname alternate.minio ```
❤️ 1
cascading-pr commented 2025-01-22 16:48:07 +00:00
Contributor
Copy link

cascading-pr updated at forgejo/runner#445

cascading-pr updated at https://code.forgejo.org/forgejo/runner/pulls/445
Kwonunn commented 2025-01-22 17:09:05 +00:00
Member
Copy link

Could this be used to potentially shadow other domain names?

Could this be used to potentially shadow other domain names?
earl-warren commented 2025-01-22 17:11:54 +00:00
Author
Contributor
Copy link

It could be abused to mess with /etc/host in various ways, but I can't think of any that would be a security concern. Do you have a specific idea in mind?

$ docker run -ti --hostname foo --rm ubuntu:noble bash
root@foo:/# cat /etc/hosts
127.0.0.1	localhost
::1	localhost ip6-localhost ip6-loopback
fe00::0	ip6-localnet
ff00::0	ip6-mcastprefix
ff02::1	ip6-allnodes
ff02::2	ip6-allrouters
172.17.0.2	foo
root@foo:/# 
exit

$ docker run -ti --hostname foo --rm ubuntu:noble cat /etc/hostname
foo
It could be abused to mess with `/etc/host` in various ways, but I can't think of any that would be a security concern. Do you have a specific idea in mind? ```sh $ docker run -ti --hostname foo --rm ubuntu:noble bash root@foo:/# cat /etc/hosts 127.0.0.1 localhost ::1 localhost ip6-localhost ip6-loopback fe00::0 ip6-localnet ff00::0 ip6-mcastprefix ff02::1 ip6-allnodes ff02::2 ip6-allrouters 172.17.0.2 foo root@foo:/# exit ``` ```sh $ docker run -ti --hostname foo --rm ubuntu:noble cat /etc/hostname foo ```
earl-warren force-pushed wip-option-hostname from d161b732ed
Some checks failed
checks / unit (pull_request) Failing after 16s
Details
checks / integration (pull_request) Has been skipped
Details
/ cascade (pull_request_target) Failing after 4m28s
Details
to d4c4e8fb11
Some checks failed
checks / unit (pull_request) Successful in 2m26s
Details
checks / integration (pull_request) Successful in 32s
Details
/ cascade (pull_request_target) Failing after 20s
Details
2025-01-22 17:48:51 +00:00 Compare
cascading-pr commented 2025-01-22 17:49:41 +00:00
Contributor
Copy link

cascading-pr updated at forgejo/runner#445

cascading-pr updated at https://code.forgejo.org/forgejo/runner/pulls/445
Kwonunn commented 2025-01-22 17:56:55 +00:00
Member
Copy link

if it's specified in the workflow file, and stays properly contained to only the host file of the containers started for that workflow it should be fine.

if it's specified in the workflow file, and stays properly contained to only the host file of the containers started for that workflow it should be fine.
👍 1
Kwonunn approved these changes 2025-01-22 18:08:37 +00:00
earl-warren scheduled this pull request to auto merge when all checks succeed 2025-01-22 18:18:50 +00:00
earl-warren canceled auto merging this pull request when all checks succeed 2025-01-22 18:22:12 +00:00
earl-warren deleted branch wip-option-hostname 2025-01-22 18:22:30 +00:00
viceice approved these changes 2025-01-23 06:38:48 +00:00
Commenting is not possible because the repository is archived.
Reviewers
No reviewers
Kwonunn
viceice
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind
Chore
Housekeeping, cleanup and chores

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind
Chore
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
earl-warren
4 participants
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
forgejo/act!95
No description provided.