forgejo/act
Archived
24
5
Fork 16
Code Issues Pull requests Releases Activity Actions

chore(lint): fix lint errors #84

Merged
earl-warren merged 1 commit from earl-warren/act:wip-lint into main 2025-01-02 08:50:27 +00:00
Conversation 4 Commits 1 Files changed 18 +28 -50
earl-warren commented 2024-12-27 08:31:10 +00:00
Contributor
Copy link
  • upgrade to [email protected]
  • make it renovate friendly
  • remove most frequent lint check that are not of consequence (unused
    args, etc.)
  • fix remaining lint errors
- upgrade to [email protected] - make it renovate friendly - remove most frequent lint check that are not of consequence (unused args, etc.) - fix remaining lint errors
earl-warren force-pushed wip-lint from aa1d676f99
Some checks failed
/ cascade (pull_request_target) Has been cancelled
Details
checks / unit (pull_request) Successful in 1m23s
Details
checks / integration (pull_request) Has been cancelled
Details
to 3f296f05f2
All checks were successful
checks / unit (pull_request) Successful in 1m37s
Details
checks / integration (pull_request) Successful in 56s
Details
/ cascade (pull_request_target) Successful in 27m19s
Details
2024-12-27 08:32:37 +00:00 Compare
cascading-pr commented 2024-12-27 08:39:44 +00:00
Contributor
Copy link

cascading-pr updated at forgejo/runner#400

cascading-pr updated at https://code.forgejo.org/forgejo/runner/pulls/400
viceice reviewed 2024-12-27 10:11:29 +00:00
Makefile Outdated
@ -5,6 +5,7 @@ MAJOR_VERSION = $(word 1, $(subst ., ,$(VERSION)))
MINOR_VERSION = $(word 2, $(subst ., ,$(VERSION)))
PATCH_VERSION = $(word 3, $(subst ., ,$(word 1,$(subst -, , $(VERSION)))))
NEW_VERSION ?= $(MAJOR_VERSION).$(MINOR_VERSION).$(shell echo $$(( $(PATCH_VERSION) + 1)) )
GOLANGCI_LINT_PACKAGE ?= github.com/golangci/golangci-lint/cmd/[email protected] # renovate: datasource=go
viceice commented 2024-12-27 10:08:50 +00:00
Owner

we need to check if renovate can find this without config modifications

we need to check if renovate can find this without config modifications
earl-warren commented 2024-12-27 21:13:29 +00:00
Author
Contributor

Right. It should probably be copied from Forgejo?

Right. It should probably be copied from Forgejo?
viceice commented 2024-12-27 21:45:56 +00:00
Owner

better moved to shared preset if not already done

better moved to shared preset if not already done
earl-warren commented 2024-12-30 21:12:48 +00:00
Author
Contributor

I copied from forgejo.

05568943c8..733b614037

I copied from forgejo. https://code.forgejo.org/forgejo/act/compare/05568943c891cd94a17d4d44c81593d77140b992..733b6140376e4c361110146c2c278bf309bf04ab
earl-warren commented 2024-12-30 21:13:52 +00:00
Author
Contributor

Is it OK to move that to forgejo/renovate-config@5a74395003/renovate.json instead?

Is it OK to move that to https://code.forgejo.org/forgejo/renovate-config/src/commit/5a743950037a65cb1d06b3c96c836fd9f881aa76/renovate.json instead?
earl-warren commented 2025-01-02 08:50:05 +00:00
Author
Contributor

It will do for now, it can be moved to the shared configuration later.

It will do for now, it can be moved to the shared configuration later.
earl-warren marked this conversation as resolved
go.mod Outdated
@ -3,3 +3,3 @@
go 1.21
toolchain go1.21.13
toolchain go1.22.10
viceice commented 2024-12-27 10:09:10 +00:00
Owner

should be a separate PR from renovate

should be a separate PR from renovate
earl-warren commented 2024-12-27 21:14:36 +00:00
Author
Contributor

Will #85 do? It needs to be updated for this version of golang-ci to run.

Will https://code.forgejo.org/forgejo/act/pulls/85 do? It needs to be updated for this version of golang-ci to run.
viceice commented 2024-12-27 21:46:39 +00:00
Owner

partly, it's also forcing a higher minimum go version, do we want that too?

partly, it's also forcing a higher minimum go version, do we want that too?
earl-warren commented 2024-12-28 08:04:45 +00:00
Author
Contributor

Given this fork of ACT is only used for the runner and the runner requires go 1.23, I see no reason not to. Or am I missing something?

Given this fork of ACT is only used for the runner and the runner requires go 1.23, I see no reason not to. Or am I missing something?
viceice commented 2024-12-28 19:48:48 +00:00
Owner

Forgejo itself also depends on it. so it will also force minimal go update for forgejo

Forgejo itself also depends on it. so it will also force minimal go update for forgejo
earl-warren commented 2024-12-28 20:41:49 +00:00
Author
Contributor

Good point 😊

Good point 😊
earl-warren commented 2024-12-29 15:37:52 +00:00
Author
Contributor

Unless.. the ACT upgrade is only for v11 which is already is at a later go version. There is no need to upgrade ACT on v10 or v7. Or am I again forgetting something?

Unless.. the ACT upgrade is only for v11 which is already is at a later go version. There is no need to upgrade ACT on v10 or v7. Or am I again forgetting something?
viceice commented 2024-12-30 20:43:19 +00:00
Owner

ok, let's bump minimum go version too

ok, let's bump minimum go version too
earl-warren marked this conversation as resolved
earl-warren force-pushed wip-lint from 3f296f05f2
All checks were successful
checks / unit (pull_request) Successful in 1m37s
Details
checks / integration (pull_request) Successful in 56s
Details
/ cascade (pull_request_target) Successful in 27m19s
Details
to 05568943c8
All checks were successful
checks / unit (pull_request) Successful in 1m18s
Details
checks / integration (pull_request) Successful in 44s
Details
/ cascade (pull_request_target) Successful in 32m23s
Details
2024-12-30 21:08:27 +00:00 Compare
cascading-pr commented 2024-12-30 21:09:24 +00:00
Contributor
Copy link

cascading-pr updated at forgejo/runner#400

cascading-pr updated at https://code.forgejo.org/forgejo/runner/pulls/400
earl-warren force-pushed wip-lint from 05568943c8
All checks were successful
checks / unit (pull_request) Successful in 1m18s
Details
checks / integration (pull_request) Successful in 44s
Details
/ cascade (pull_request_target) Successful in 32m23s
Details
to 733b614037
Some checks failed
checks / unit (pull_request) Successful in 1m25s
Details
checks / integration (pull_request) Successful in 41s
Details
/ cascade (pull_request_target) Failing after 22s
Details
2024-12-30 21:11:49 +00:00 Compare
cascading-pr commented 2024-12-30 21:13:53 +00:00
Contributor
Copy link

cascading-pr updated at forgejo/runner#400

cascading-pr updated at https://code.forgejo.org/forgejo/runner/pulls/400
earl-warren deleted branch wip-lint 2025-01-02 08:50:27 +00:00
Commenting is not possible because the repository is archived.
Reviewers
No reviewers
viceice
Kwonunn
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind
Chore
Housekeeping, cleanup and chores

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind
Chore
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
earl-warren
3 participants
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
forgejo/act!84
No description provided.