forgejo/act
Archived
24
5
Fork 16
Code Issues Pull requests Releases Activity Actions

feat: prefer FORGEJO_TOKEN for runtime token #82

Closed
xtex wants to merge 1 commit from xtex/act:forgejo-token into main
pull from: xtex/act:forgejo-token
merge into: forgejo:main
Conversation 8 Commits 1 Files changed 4 +15 -5
xtex commented 2024-12-13 13:11:56 +00:00
Contributor
Copy link

Tries to get runtime token from FORGEJO_TOKEN. This improves Forgejo branding.

Tries to get runtime token from FORGEJO_TOKEN. This improves Forgejo branding.
cascading-pr commented 2024-12-13 13:12:49 +00:00
Contributor
Copy link

cascading-pr updated at forgejo/runner#390

cascading-pr updated at https://code.forgejo.org/forgejo/runner/pulls/390
viceice reviewed 2024-12-14 13:00:31 +00:00
viceice left a comment
Owner

please fill PR description with reason why this is useful

please fill PR description with reason why this is useful
pkg/runner/runner.go Outdated
@ -81,3 +81,3 @@
func (c Config) GetToken() string {
token := c.Secrets["GITHUB_TOKEN"]
token := c.Secrets["FORGEJO_TOKEN"]
if c.Secrets["GITEA_TOKEN"] != "" {
viceice commented 2024-12-14 13:00:09 +00:00
Owner

I think we should only overwrite the token if not already set?

I think we should only overwrite the token if not already set?
xtex marked this conversation as resolved
xtex force-pushed forgejo-token from 50dcecd6a5
All checks were successful
checks / unit (pull_request) Successful in 43s
Details
checks / integration (pull_request) Successful in 26s
Details
/ cascade (pull_request_target) Successful in 29m44s
Details
to b8b24724f3
All checks were successful
checks / unit (pull_request) Successful in 31s
Details
checks / integration (pull_request) Successful in 30s
Details
/ cascade (pull_request_target) Successful in 39s
Details
2024-12-14 13:35:26 +00:00 Compare
earl-warren commented 2024-12-15 07:32:39 +00:00
Contributor
Copy link

Can you please explain why this change is necessary? It is already done in the runner and I don't recall why it would be needed in the ACT fork 🤔

Can you please explain why this change is necessary? It is already done in the runner and I don't recall why it would be needed in the ACT fork 🤔
earl-warren commented 2024-12-25 14:28:02 +00:00
Contributor
Copy link

@xtex gentle ping

@xtex gentle ping
xtex commented 2024-12-28 10:52:59 +00:00
Author
Contributor
Copy link

It is unnecessary, really, except for the FORGEJO_TOKEN environment variable exposure, which is for branding improvement. Other changes are redundant and removable.

It is unnecessary, really, except for the FORGEJO_TOKEN environment variable exposure, which is for branding improvement. Other changes are redundant and removable.
earl-warren commented 2024-12-28 20:18:24 +00:00
Contributor
Copy link

Could you split the exposure of the variable to a separate pull request so it can be merged? The behavior change would need testing and is less trivial.

Could you split the exposure of the variable to a separate pull request so it can be merged? The behavior change would need testing and is less trivial.
cascading-pr commented 2025-01-11 11:00:58 +00:00
Contributor
Copy link

cascading-pr updated at forgejo/runner#390

cascading-pr updated at https://code.forgejo.org/forgejo/runner/pulls/390
earl-warren commented 2025-05-26 05:09:49 +00:00
Contributor
Copy link

Please re-open when you have time to work on this 🙏

Please re-open when you have time to work on this 🙏
earl-warren closed this pull request 2025-05-26 05:09:50 +00:00
Commenting is not possible because the repository is archived.
Reviewers
No reviewers
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind
Chore
Housekeeping, cleanup and chores

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind
Chore
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
forgejo/act!82
No description provided.