forgejo/act
Archived
24
5
Fork 16
Code Issues Pull requests Releases Activity Actions

fix: log skipped job and step result as info instead of debug #67

Merged
earl-warren merged 1 commit from earl-warren/act:wip-runner-test into main 2024-11-21 13:25:46 +00:00
Conversation 7 Commits 1 Files changed 6 +73 -9
earl-warren commented 2024-11-21 10:35:45 +00:00
Contributor
Copy link

This allows the Forgejo runner to obtain the job result from the logs even when it is not in debug mode.

Refs: https://codeberg.org/forgejo/forgejo/issues/5939

Note to reviewers: the test does not provide coverage for all the changes, only those related to step results being skipped. I advocate that although incomplete, this is a reasonable effort to provide coverage.

This allows the Forgejo runner to obtain the job result from the logs even when it is not in debug mode. Refs: https://codeberg.org/forgejo/forgejo/issues/5939 Note to reviewers: the test does not provide coverage for all the changes, only those related to step results being skipped. I advocate that although incomplete, this is a reasonable effort to provide coverage.
earl-warren force-pushed wip-runner-test from 2dd8535255
Some checks failed
/ cascade (pull_request_target) Has been skipped
Details
checks / unit (pull_request) Successful in 7m3s
Details
checks / integration (pull_request) Failing after 17s
Details
to 8ebe416a9d
Some checks failed
/ cascade (pull_request_target) Has been skipped
Details
checks / unit (pull_request) Successful in 23s
Details
checks / integration (pull_request) Failing after 17s
Details
2024-11-21 10:45:44 +00:00 Compare
earl-warren force-pushed wip-runner-test from 8ebe416a9d
Some checks failed
/ cascade (pull_request_target) Has been skipped
Details
checks / unit (pull_request) Successful in 23s
Details
checks / integration (pull_request) Failing after 17s
Details
to 18d34b2a0f
All checks were successful
/ cascade (pull_request_target) Has been skipped
Details
checks / unit (pull_request) Successful in 23s
Details
checks / integration (pull_request) Successful in 40s
Details
2024-11-21 10:49:45 +00:00 Compare
earl-warren force-pushed wip-runner-test from 54481c3d04
Some checks failed
/ cascade (pull_request_target) Has been skipped
Details
checks / unit (pull_request) Successful in 23s
Details
checks / integration (pull_request) Failing after 28s
Details
to f682e89ff0
All checks were successful
/ cascade (pull_request_target) Has been skipped
Details
checks / unit (pull_request) Successful in 25s
Details
checks / integration (pull_request) Successful in 28s
Details
2024-11-21 11:55:49 +00:00 Compare
earl-warren force-pushed wip-runner-test from f682e89ff0
All checks were successful
/ cascade (pull_request_target) Has been skipped
Details
checks / unit (pull_request) Successful in 25s
Details
checks / integration (pull_request) Successful in 28s
Details
to 6f86daa82b
All checks were successful
/ cascade (pull_request_target) Has been skipped
Details
checks / unit (pull_request) Successful in 23s
Details
checks / integration (pull_request) Successful in 28s
Details
2024-11-21 11:57:16 +00:00 Compare
earl-warren force-pushed wip-runner-test from 6f86daa82b
All checks were successful
/ cascade (pull_request_target) Has been skipped
Details
checks / unit (pull_request) Successful in 23s
Details
checks / integration (pull_request) Successful in 28s
Details
to b87469f77b
Some checks failed
checks / unit (pull_request) Successful in 23s
Details
checks / integration (pull_request) Successful in 28s
Details
/ cascade (pull_request_target) Has been cancelled
Details
2024-11-21 11:58:51 +00:00 Compare
earl-warren changed title from WIP: fix: log skipped job and step result as info instead of debug to fix: log skipped job and step result as info instead of debug 2024-11-21 11:59:10 +00:00
cascading-pr commented 2024-11-21 12:06:28 +00:00
Contributor
Copy link

cascading-pr updated at forgejo/runner#348

cascading-pr updated at https://code.forgejo.org/forgejo/runner/pulls/348
viceice reviewed 2024-11-21 12:12:59 +00:00
viceice left a comment
Owner

otherwise LGTM

otherwise LGTM
.forgejo/workflows/test.yml Outdated
@ -17,4 +16,3 @@
container:
image: 'code.forgejo.org/oci/node:20-bookworm'
steps:
- name: cache go path
viceice commented 2024-11-21 12:10:42 +00:00
Owner

why removing this? 🤔

why removing this? 🤔
earl-warren commented 2024-11-21 12:16:51 +00:00
Author
Contributor

I thought to cleanup but it was incomplete, good catch. I put it back.

I thought to cleanup but it was incomplete, good catch. I put it back.
earl-warren marked this conversation as resolved
earl-warren force-pushed wip-runner-test from b87469f77b
Some checks failed
checks / unit (pull_request) Successful in 23s
Details
checks / integration (pull_request) Successful in 28s
Details
/ cascade (pull_request_target) Has been cancelled
Details
to 7efe12afd7
Some checks failed
checks / check and test (pull_request) Successful in 26s
Details
checks / integration (pull_request) Successful in 27s
Details
/ cascade (pull_request_target) Has been cancelled
Details
2024-11-21 12:16:32 +00:00 Compare
cascading-pr commented 2024-11-21 12:17:23 +00:00
Contributor
Copy link

cascading-pr updated at forgejo/runner#348

cascading-pr updated at https://code.forgejo.org/forgejo/runner/pulls/348
earl-warren force-pushed wip-runner-test from 7efe12afd7
Some checks failed
checks / check and test (pull_request) Successful in 26s
Details
checks / integration (pull_request) Successful in 27s
Details
/ cascade (pull_request_target) Has been cancelled
Details
to fc43985812
Some checks failed
checks / unit (pull_request) Successful in 43s
Details
checks / integration (pull_request) Successful in 33s
Details
/ cascade (pull_request_target) Failing after 21s
Details
2024-11-21 12:18:10 +00:00 Compare
viceice approved these changes 2024-11-21 12:18:57 +00:00
cascading-pr commented 2024-11-21 12:20:06 +00:00
Contributor
Copy link

cascading-pr updated at forgejo/runner#348

cascading-pr updated at https://code.forgejo.org/forgejo/runner/pulls/348
earl-warren scheduled this pull request to auto merge when all checks succeed 2024-11-21 12:20:34 +00:00
cascading-pr commented 2024-11-21 12:46:52 +00:00
Contributor
Copy link

cascading-pr updated at forgejo/runner#348

cascading-pr updated at https://code.forgejo.org/forgejo/runner/pulls/348
earl-warren commented 2024-11-21 13:03:58 +00:00
Author
Contributor
Copy link

end-to-end had a transient failure in the storage upgrade (failure to populate the cache with tools that sometime fail to download)

https://code.forgejo.org/forgejo/end-to-end/actions/runs/1978

end-to-end had a transient failure in the storage upgrade (failure to populate the cache with tools that sometime fail to download) https://code.forgejo.org/forgejo/end-to-end/actions/runs/1978
earl-warren deleted branch wip-runner-test 2024-11-21 13:25:46 +00:00
Commenting is not possible because the repository is archived.
Reviewers
No reviewers
Kwonunn
viceice
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind
Chore
Housekeeping, cleanup and chores

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind
Chore
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
earl-warren
3 participants
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
forgejo/act!67
No description provided.