[FORGEJO] when a workflow decode error happen, log and do not crash #54

earl-warren · 2024-09-15T13:48:55Z

earl-warren commented

2024-09-15 13:48:55 +00:00

No description provided.

earl-warren added 1 commit

2024-09-15 13:48:55 +00:00

[FORGEJO] when a workflow decode error happen, log and do not crash

checks / check and test (pull_request) Successful in 6m57s

Details

/ cascade (pull_request) Failing after 14s

Details

a7db265415

earl-warren requested review from fnetX

2024-09-15 13:49:06 +00:00

cascading-pr commented

2024-09-15 13:51:09 +00:00

Cascade of tests using this pull request of ACT

runner tests forgejo/runner#268
setup-forgejo tests actions/setup-forgejo#150
end-to-end tests forgejo/end-to-end#273

Cascade of tests using this pull request of ACT * runner tests https://code.forgejo.org/forgejo/runner/pulls/268 * setup-forgejo tests https://code.forgejo.org/actions/setup-forgejo/pulls/150 * end-to-end tests https://code.forgejo.org/forgejo/end-to-end/pulls/273

viceice approved these changes

2024-09-15 14:14:38 +00:00

Dismissed

viceice left a comment

otherwise LGTM

.forgejo/workflows/test.yml

					
				@ -45,3 +45,3 @@

				        run: go build -tags WITHOUT_DOCKER -v ./...

				      - name: test

				        run: go test -v ./pkg/jobparser

				        run: go test -v ./pkg/jobparser ./pkg/model

why this?

because the tests in pkg/model were not run before.

because the tests in `pkg/model` were not run before.

should we use ./... to run all tests?

should we use `./...` to run all tests?

I don't think it will work but I forgot why. I opened a pull request for that at #55

I don't think it will work but I forgot why. I opened a pull request for that at https://code.forgejo.org/forgejo/act/pulls/55