forgejo/act
Archived
24
5
Fork 16
Code Issues Pull requests Releases Activity Actions

fix(jobparser): support workflow_dispatch.inputs #45

Merged
earl-warren merged 1 commit from viceice/fix-inputs into main 2024-08-22 14:10:57 +00:00 AGit
Conversation 8 Commits 1 Files changed 2 +13
viceice commented 2024-08-22 12:25:37 +00:00
Owner
Copy link

Currently the jobparser fails on workflow_dispatch.inputs

Currently the jobparser fails on `workflow_dispatch.inputs` - https://codeberg.org/forgejo/forgejo/issues/4789
viceice force-pushed viceice/fix-inputs from b87e8a5a09
All checks were successful
/ cascade (pull_request) Has been skipped
Details
checks / check and test (pull_request) Successful in 7m12s
Details
to 6a1630ba4c
All checks were successful
/ cascade (pull_request) Has been skipped
Details
checks / check and test (pull_request) Successful in 26s
Details
2024-08-22 12:58:56 +00:00 Compare
viceice force-pushed viceice/fix-inputs from 6a1630ba4c
All checks were successful
/ cascade (pull_request) Has been skipped
Details
checks / check and test (pull_request) Successful in 26s
Details
to 03fca1736d
All checks were successful
/ cascade (pull_request) Has been skipped
Details
checks / check and test (pull_request) Successful in 14s
Details
2024-08-22 13:01:17 +00:00 Compare
viceice force-pushed viceice/fix-inputs from 03fca1736d
All checks were successful
/ cascade (pull_request) Has been skipped
Details
checks / check and test (pull_request) Successful in 14s
Details
to be182ffdfa
All checks were successful
checks / check and test (pull_request) Successful in 15s
Details
/ cascade (pull_request) Has been skipped
Details
2024-08-22 13:02:09 +00:00 Compare
Ghost approved these changes 2024-08-22 13:02:22 +00:00
Ghost left a comment

LGTM.

Explicitly requested review.

LGTM. *Explicitly requested review.*
Mai-Lapyst commented 2024-08-22 13:24:42 +00:00
Member
Copy link

I think this will break actions loaded via uses, as they're also using the input context in their action.yml to refer to the inputs suppied in with. Have you tested this?

~~I think this will break actions loaded via `uses`, as they're also using the `input` context in their `action.yml` to refer to the inputs suppied in `with`. Have you tested this?~~
viceice commented 2024-08-22 13:41:37 +00:00
Author
Owner
Copy link

I think this will break actions loaded via uses, as they're also using the input context in their action.yml to refer to the inputs suppied in with. Have you tested this?

No, jobparser.ParseRawOn is only called once inside Forgejo and not used inside forgejo-runner.

codeberg.org/forgejo/forgejo@8322882265/modules/actions/workflows.go (L93)

> I think this will break actions loaded via `uses`, as they're also using the `input` context in their `action.yml` to refer to the inputs suppied in `with`. Have you tested this? No, `jobparser.ParseRawOn` is only called once inside Forgejo and not used inside forgejo-runner. https://codeberg.org/forgejo/forgejo/src/commit/8322882265c249daf9d8ff950ce2ece34296da9b/modules/actions/workflows.go#L93
earl-warren commented 2024-08-22 14:03:58 +00:00
Contributor
Copy link

@Mai-Lapyst I tested that it fixes the bug at forgejo/end-to-end#252 (comment)

I will run the other tests from https://code.forgejo.org/forgejo/end-to-end/actions locally too and see if any of them break. In particular:

Both of which have uses: with input (local & remote actions).

@Mai-Lapyst I tested that it fixes the bug at https://code.forgejo.org/forgejo/end-to-end/pulls/252#issuecomment-12240 I will run the other tests from https://code.forgejo.org/forgejo/end-to-end/actions locally too and see if any of them break. In particular: * https://code.forgejo.org/forgejo/end-to-end/src/branch/main/actions/example-local-action/.forgejo/workflows/test.yml * https://code.forgejo.org/forgejo/end-to-end/src/branch/main/actions/example-cache/.forgejo/workflows/test.yml Both of which have `uses:` with input (local & remote actions).
earl-warren commented 2024-08-22 14:07:00 +00:00
Contributor
Copy link

Both of which have uses: with input (local & remote actions).

Both pass.

> * https://code.forgejo.org/forgejo/end-to-end/src/branch/main/actions/example-local-action/.forgejo/workflows/test.yml > * https://code.forgejo.org/forgejo/end-to-end/src/branch/main/actions/example-cache/.forgejo/workflows/test.yml > > Both of which have `uses:` with input (local & remote actions). Both pass.
Mai-Lapyst commented 2024-08-22 14:07:28 +00:00
Member
Copy link

My bad; I just misread https://codeberg.org/forgejo/forgejo/issues/4789 and thought it was about the variable expansion not working (${{ inputs.some_input }}). Didn't ever realized that forgejo actually had an error with event detection in the workflow files since they always just popped up in the UI just fine. My comment is therefore nonesense and the PR is good.

My bad; I just misread https://codeberg.org/forgejo/forgejo/issues/4789 and thought it was about the variable expansion not working (`${{ inputs.some_input }}`). Didn't ever realized that forgejo actually had an error with event detection in the workflow files since they always just popped up in the UI just fine. My comment is therefore nonesense and the PR is good.
❤️ 1
earl-warren commented 2024-08-22 14:12:04 +00:00
Contributor
Copy link

For the record, all tests were run with a runner also compiled with this version of act. There is no automated way / cascade flow that would allow for a semi-automated version of the same: it had to be done manually.

For the record, all tests were run with a runner also compiled with this version of act. There is no automated way / cascade flow that would allow for a semi-automated version of the same: it had to be done manually.
Commenting is not possible because the repository is archived.
Reviewers
No reviewers
Mai-Lapyst
Ghost
earl-warren
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind
Chore
Housekeeping, cleanup and chores

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind
Chore
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
forgejo/act!45
No description provided.