forgejo/act
Archived
24
5
Fork 16
Code Issues Pull requests Releases Activity Actions

fix(jobparser): template job name if it's defined #41

Merged
Ghost merged 1 commit from thefox/job-matrix into main 2024-07-01 19:49:31 +00:00 AGit
Conversation 5 Commits 1 Files changed 4 +126 -3
Ghost commented 2024-07-01 18:28:55 +00:00
Copy link

fixes name overwrite in parser

fixes name overwrite in parser
fix(jobparser): template job name if it's defined
All checks were successful
checks / check and test (pull_request) Successful in 6m51s
Details
/ cascade (pull_request) Has been skipped
Details
39a5735dc7
viceice approved these changes 2024-07-01 19:08:31 +00:00
viceice left a comment
Owner

❤️

❤️
Ghost merged commit e89fbf5d6a into main 2024-07-01 19:49:31 +00:00
earl-warren commented 2024-07-01 20:26:05 +00:00
Contributor
Copy link

This needs to be tested all the way up to end-to-end before being merged.

This needs to be tested all the way up to end-to-end before being merged.
Ghost commented 2024-07-01 20:31:13 +00:00
Copy link

Honestly I have no idea how act is even versioned when it's a softfork. Looking at it I think I get why the forgejo being a softfork was less then ideal to work with.

But yes, I'll see about making a test in e2e for this.

Honestly I have no idea how act is even versioned when it's a softfork. Looking at it I think I get why the forgejo being a softfork was less then ideal to work with. But yes, I'll see about making a test in e2e for this.
earl-warren commented 2024-07-01 20:46:42 +00:00
Contributor
Copy link

That's not what I meant, sorry for not being clear. There is a chain of tests starting from this repository that can run the end-to-end tests using a runner built with this version of act.

Having additional tests in end-to-end might be good but I'm more concerned about the potential regressions. Not very but always :-)

Can I propose you open a new PR to fix a typo or something in this repo and I'll show you how it is done. It is not super confortable but not entirely absurd either.

That's not what I meant, sorry for not being clear. There is a chain of tests starting from this repository that can run the end-to-end tests using a runner built with this version of act. Having additional tests in end-to-end might be good but I'm more concerned about the potential regressions. Not very but always :-) Can I propose you open a new PR to fix a typo or something in this repo and I'll show you how it is done. It is not super confortable but not entirely absurd either.
Ghost commented 2024-07-01 21:31:48 +00:00
Copy link

Sure, sorry for jumping the gun here then: #42

Sure, sorry for jumping the gun here then: https://code.forgejo.org/forgejo/act/pulls/42
❤️ 1
Commenting is not possible because the repository is archived.
Reviewers
No reviewers
viceice
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind
Chore
Housekeeping, cleanup and chores

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind
Chore
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
forgejo/act!41
No description provided.