forgejo/act

Archived

Fork 16

[FORGEJO] a network of "" is not the same as "host" #35

Merged

earl-warren merged 1 commit from earl-warren/act:wip-network into main

2024-03-24 11:58:35 +00:00

earl-warren commented

2024-03-24 11:11:15 +00:00

Contributor

The hunk is reverted.

https://github.com/nektos/act/pull/1949/files#r1315163582

The comment that introduced this change suggests it was motivated by a border case by which the image would be empty. It is however unclear why it should have any impact on how the network name is determined. The hunk is reverted. https://github.com/nektos/act/pull/1949/files#r1315163582

earl-warren added 1 commit

2024-03-24 11:11:15 +00:00

[FORGEJO] a network of "" is not the same as "host"

checks / check and test (pull_request) Successful in 6m58s

Details

/ cascade (pull_request) Has been skipped

Details

09d179c15b

The comment that introduced this change suggests it was motivated by a
border case by which the image would be empty. It is however unclear
why it should have any impact on how the network name is determined.

The hunk is reverted.

https://github.com/nektos/act/pull/1949/files#r1315163582

cascading-pr commented

2024-03-24 11:14:12 +00:00

Contributor

cascading-pr updated at forgejo/runner#166

cascading-pr updated at https://code.forgejo.org/forgejo/runner/pulls/166

cascading-pr commented

2024-03-24 11:29:34 +00:00

Contributor

cascading-pr updated at forgejo/runner#166

cascading-pr updated at https://code.forgejo.org/forgejo/runner/pulls/166

twenty-panda approved these changes

2024-03-24 11:35:54 +00:00

earl-warren referenced this pull request from forgejo/runner

2024-03-24 11:37:51 +00:00

upgrade to ACT v1.20.1 #167

viceice approved these changes

2024-03-24 11:45:17 +00:00

viceice commented

2024-03-24 11:47:51 +00:00

Owner

should we upstream it? I think it's an issue there too.

earl-warren commented

2024-03-24 11:53:30 +00:00

Author

Contributor

Passed end to end.

Passed [end to end](https://code.forgejo.org/forgejo/end-to-end/actions/runs/946/jobs/2#jobstep-3-543).

🎉 1

earl-warren commented

2024-03-24 11:58:16 +00:00

Author

Contributor

should we upstream it? I think it's an issue there too.

I would wait: the entire service patch in ACT is going to be reverted in the next few days in the Gitea fork because there was concerns it has other regressions. I can't find the discussion right now, it is somewhere in the issues. I'm happy to let the dust settle and see what happens.

> should we upstream it? I think it's an issue there too. I would wait: the entire service patch in ACT is going to be reverted in the next few days in the Gitea fork because there was concerns it has other regressions. I can't find the discussion right now, it is somewhere in the issues. I'm happy to let the dust settle and see what happens.

earl-warren merged commit af0a149a4d into main

2024-03-24 11:58:35 +00:00

earl-warren deleted branch wip-network

2024-03-24 11:58:35 +00:00

earl-warren referenced this pull request from a commit

2024-03-24 11:58:36 +00:00

Merge pull request '[FORGEJO] a network of "" is not the same as "host"' (#35) from earl-warren/act:wip-network into main

viceice commented

2024-03-24 12:16:03 +00:00

Owner

should we upstream it? I think it's an issue there too.

I would wait: the entire service patch in ACT is going to be reverted in the next few days in the Gitea fork because there was concerns it has other regressions. I can't find the discussion right now, it is somewhere in the issues. I'm happy to let the dust settle and see what happens.

plausible 👍

> > should we upstream it? I think it's an issue there too. > > I would wait: the entire service patch in ACT is going to be reverted in the next few days in the Gitea fork because there was concerns it has other regressions. I can't find the discussion right now, it is somewhere in the issues. I'm happy to let the dust settle and see what happens. plausible 👍

earl-warren commented

2024-03-24 12:42:37 +00:00

Author

Contributor

https://gitea.com/gitea/act/issues/99 is the corresponding discussion.

👍 1

earl-warren referenced this pull request from a commit

2025-07-28 17:10:28 +00:00

Merge pull request '[FORGEJO] a network of "" is not the same as "host"' (#35) from earl-warren/act:wip-network into main

Commenting is not possible because the repository is archived.

No reviewers