forgejo/act
Archived
24
5
Fork 16
Code Issues Pull requests Releases Activity Actions

chore(tests): add coverage for ./pkg/runner #202

Merged
earl-warren merged 1 commit from earl-warren/act:wip-test-runner into main 2025-07-28 06:18:47 +00:00
Conversation 1 Commits 1 Files changed 66 +196 -640
earl-warren commented 2025-07-26 17:03:48 +00:00
Contributor
Copy link

Only changes test files.

  • remove tests specific to running on a host with no container
    they are the same as with the containers (TestRunEventHostEnvironment)
  • prefix the name of the tests with a distinctive name to
    more easily run them together
  • use code.forgejo.org/oci images whereever possible
  • remove some tests that are either
    • difficult to understand (ancient bugs)
    • not yet well understood (related to reusable workflows)
    • depend on github (generation of workflows to be run on the fly
      e.g. updateTestIfWorkflow)
  • fix the TestSanitizeNetworkAlias tests that were not run
    and make them easier to debug
  • disable tests of options that are forbidden in Forgejo Actions
    (testdata/container-hostname/push.yml)
Only changes test files. --- - remove tests specific to running on a host with no container they are the same as with the containers (TestRunEventHostEnvironment) - prefix the name of the tests with a distinctive name to more easily run them together - use code.forgejo.org/oci images whereever possible - remove some tests that are either - difficult to understand (ancient bugs) - not yet well understood (related to reusable workflows) - depend on github (generation of workflows to be run on the fly e.g. updateTestIfWorkflow) - fix the TestSanitizeNetworkAlias tests that were not run and make them easier to debug - disable tests of options that are forbidden in Forgejo Actions (testdata/container-hostname/push.yml)
earl-warren force-pushed wip-test-runner from fe98537c99
All checks were successful
/ cascade (pull_request_target) Has been skipped
Details
checks / unit (pull_request) Successful in 2m54s
Details
checks / integration (pull_request) Successful in 2m18s
Details
to 8ae5dc86c2
All checks were successful
/ cascade (pull_request_target) Has been skipped
Details
checks / unit (pull_request) Successful in 2m50s
Details
checks / integration (pull_request) Successful in 2m14s
Details
2025-07-26 17:04:28 +00:00 Compare
earl-warren force-pushed wip-test-runner from 8ae5dc86c2
All checks were successful
/ cascade (pull_request_target) Has been skipped
Details
checks / unit (pull_request) Successful in 2m50s
Details
checks / integration (pull_request) Successful in 2m14s
Details
to 16931c4107
Some checks failed
/ cascade (pull_request_target) Has been skipped
Details
checks / unit (pull_request) Failing after 47s
Details
checks / integration (pull_request) Has been skipped
Details
2025-07-26 17:37:58 +00:00 Compare
earl-warren force-pushed wip-test-runner from 16931c4107
Some checks failed
/ cascade (pull_request_target) Has been skipped
Details
checks / unit (pull_request) Failing after 47s
Details
checks / integration (pull_request) Has been skipped
Details
to cb6154ebd6
Some checks failed
/ cascade (pull_request_target) Has been skipped
Details
checks / unit (pull_request) Failing after 55s
Details
checks / integration (pull_request) Has been skipped
Details
2025-07-27 20:35:20 +00:00 Compare
earl-warren force-pushed wip-test-runner from cb6154ebd6
Some checks failed
/ cascade (pull_request_target) Has been skipped
Details
checks / unit (pull_request) Failing after 55s
Details
checks / integration (pull_request) Has been skipped
Details
to a41630e36a
Some checks failed
/ cascade (pull_request_target) Has been skipped
Details
checks / unit (pull_request) Failing after 41s
Details
checks / integration (pull_request) Has been skipped
Details
2025-07-27 20:38:08 +00:00 Compare
earl-warren force-pushed wip-test-runner from d1da6e28f8
All checks were successful
/ cascade (pull_request_target) Has been skipped
Details
checks / unit (pull_request) Successful in 1m49s
Details
checks / integration (pull_request) Successful in 9m31s
Details
to 9c367d7819
All checks were successful
/ cascade (pull_request_target) Has been skipped
Details
checks / unit (pull_request) Successful in 1m50s
Details
checks / integration (pull_request) Successful in 9m32s
Details
2025-07-27 21:34:47 +00:00 Compare
earl-warren changed title from WIP: chore(tests): add coverage for ./pkg/runner [skip cascade] to chore(tests): add coverage for ./pkg/runner [skip cascade] 2025-07-27 21:36:57 +00:00
earl-warren force-pushed wip-test-runner from 4738808bc5
Some checks failed
/ cascade (pull_request_target) Has been skipped
Details
checks / unit (pull_request) Successful in 1m46s
Details
checks / integration (pull_request) Failing after 8m59s
Details
to 7fd18746d6
All checks were successful
/ cascade (pull_request_target) Has been skipped
Details
checks / unit (pull_request) Successful in 1m51s
Details
checks / integration (pull_request) Successful in 9m30s
Details
2025-07-27 22:16:26 +00:00 Compare
earl-warren force-pushed wip-test-runner from 7fd18746d6
All checks were successful
/ cascade (pull_request_target) Has been skipped
Details
checks / unit (pull_request) Successful in 1m51s
Details
checks / integration (pull_request) Successful in 9m30s
Details
to 4745247d02
Some checks failed
checks / unit (pull_request) Successful in 1m48s
Details
checks / integration (pull_request) Successful in 8m46s
Details
/ cascade (pull_request_target) Failing after 56s
Details
2025-07-27 22:30:18 +00:00 Compare
viceice approved these changes 2025-07-28 04:54:56 +00:00
earl-warren changed title from chore(tests): add coverage for ./pkg/runner [skip cascade] to chore(tests): add coverage for ./pkg/runner 2025-07-28 06:18:26 +00:00
earl-warren deleted branch wip-test-runner 2025-07-28 06:18:47 +00:00
Commenting is not possible because the repository is archived.
Reviewers
No reviewers
Maks1mS
viceice
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind
Chore
Housekeeping, cleanup and chores

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind
Chore
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
earl-warren
2 participants
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
forgejo/act!202
No description provided.