forgejo/act
Archived
24
5
Fork 16
Code Issues Pull requests Releases Activity Actions

fix: sanitize network aliases to be valid DNS names (part 2) #197

Merged
earl-warren merged 1 commit from earl-warren/act:wip-dns into main 2025-07-26 11:31:06 +00:00
Conversation 3 Commits 1 Files changed 2 +6 -6
earl-warren commented 2025-07-26 10:32:33 +00:00
Contributor
Copy link
  • prefer the lowercase version of the DNS name which is more common they are case insensitive anyway
  • fix the inverted information when sanitation happens
- prefer the lowercase version of the DNS name which is more common they are case insensitive anyway - fix the inverted information when sanitation happens
fix: sanitize network aliases to be valid DNS names (part 2)
Some checks failed
checks / unit (pull_request) Successful in 2m57s
Details
checks / integration (pull_request) Successful in 2m11s
Details
/ cascade (pull_request_target) Failing after 33s
Details
257dfbf350
 
- prefer the lowercase version of the DNS name which is more common they are case insensitive anyway
- fix the inverted information when sanitation happens
cascading-pr commented 2025-07-26 10:33:26 +00:00
Contributor
Copy link

cascading-pr updated at forgejo/runner#737

cascading-pr updated at https://code.forgejo.org/forgejo/runner/pulls/737
msrd0 approved these changes 2025-07-26 10:53:20 +00:00
msrd0 left a comment
Member

LGTM

LGTM
❤️ 1
earl-warren deleted branch wip-dns 2025-07-26 11:31:06 +00:00
viceice approved these changes 2025-07-26 13:48:10 +00:00
Commenting is not possible because the repository is archived.
Reviewers
No reviewers
msrd0
viceice
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind
Chore
Housekeeping, cleanup and chores

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind
Chore
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
earl-warren
4 participants
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
forgejo/act!197
No description provided.