fix: jobparser: do not crash on invalid workflow_{dispatch,call} #193

Merged

earl-warren merged 1 commit from earl-warren/act:wip-jobparser into main

2025-07-25 11:30:48 +00:00

earl-warren commented

2025-07-25 08:52:47 +00:00

Contributor

go test -count=500 -run=TestParseRawOn/on:___workflow_ -v ./pkg/jobparser/

Regression from #45

An invalid workflow_{dispatch,call} key with a type that is not a map may attempt to use a nil map. It happens randomly as the order of the key maps is not guaranteed. Without this fix, the tests will fail 100% of the time with: `go test -count=500 -run=TestParseRawOn/on:___workflow_ -v ./pkg/jobparser/` Regression from https://code.forgejo.org/forgejo/act/pulls/45

earl-warren added the

Kind/Bug

label

2025-07-25 08:52:47 +00:00

earl-warren self-assigned this

2025-07-25 08:52:47 +00:00

earl-warren added 1 commit

2025-07-25 08:52:47 +00:00

fix: jobparser: do not crash on invalid workflow_{dispatch,call}

checks / unit (pull_request) Successful in 2m52s

Details

checks / integration (pull_request) Successful in 1m55s

Details

/ cascade (pull_request_target) Failing after 40s

Details

7ada80b8a3

An invalid workflow_{dispatch,call} key with a type that is not
a map may attempt to use a nil map. It happens randomly as the
order of the key maps is not guaranteed. Without this fix, the tests
will fail 100% of the time with:

go test -count=500 -run=TestParseRawOn/on:___workflow_ -v ./pkg/jobparser/

Regression from #45

earl-warren requested review from viceice

2025-07-25 08:53:06 +00:00