forgejo/act
Archived
24
5
Fork 16
Code Issues Pull requests Releases Activity Actions

fix: sum256 the container name so derivations do not overflow #191

Merged
earl-warren merged 1 commit from earl-warren/act:wip-name-sum256 into main 2025-07-25 09:44:26 +00:00
Conversation 3 Commits 1 Files changed 4 +28 -5
earl-warren commented 2025-07-23 15:08:55 +00:00
Contributor
Copy link

For instance, the volume name derived from the workflow name may exceed the file system limit when the container name it is derived from is too long.

Fixes forgejo/runner#152

For instance, the volume name derived from the workflow name may exceed the file system limit when the container name it is derived from is too long. Fixes forgejo/runner#152
earl-warren changed title from fix: sum256 the container name so derivations do not overflow [skip cascade] to fix: sum256 the container name so derivations do not overflow 2025-07-23 16:05:18 +00:00
earl-warren force-pushed wip-name-sum256 from 31e2c6a67e
All checks were successful
/ cascade (pull_request_target) Has been skipped
Details
checks / unit (pull_request) Successful in 2m28s
Details
checks / integration (pull_request) Successful in 2m54s
Details
to 0dae7da567
Some checks failed
checks / unit (pull_request) Successful in 1m59s
Details
checks / integration (pull_request) Successful in 2m16s
Details
/ cascade (pull_request_target) Failing after 32s
Details
2025-07-23 16:05:33 +00:00 Compare
cascading-pr commented 2025-07-23 16:06:31 +00:00
Contributor
Copy link

cascading-pr updated at forgejo/runner#728

cascading-pr updated at https://code.forgejo.org/forgejo/runner/pulls/728
viceice approved these changes 2025-07-23 20:12:25 +00:00
viceice left a comment
Owner

another breaking change

another breaking change
earl-warren commented 2025-07-23 20:20:23 +00:00
Author
Contributor
Copy link

How so? AFAIU it is entirely transparent. Only if you monitor the docker activity will you see the names do not look the same. Or did I miss something?

How so? AFAIU it is entirely transparent. Only if you monitor the docker activity will you see the names do not look the same. Or did I miss something?
earl-warren deleted branch wip-name-sum256 2025-07-25 09:44:27 +00:00
Commenting is not possible because the repository is archived.
Reviewers
No reviewers
msrd0
viceice
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind
Chore
Housekeeping, cleanup and chores

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind
Chore
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
earl-warren
3 participants
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
forgejo/act!191
No description provided.