fix: sanitize network aliases to be valid DNS names #190
No reviewers
viceice
Labels
No labels
Compat/Breaking
Kind/Bug
Kind
Chore
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
3 participants
No due date set.
Dependencies
No dependencies set.
Reference
forgejo/act!190
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "earl-warren/act:wip-dns"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes forgejo/runner#226
It is breaking because it will fail jobs that rely on service names that contain characters that are sanitized
cascading-pr updated at forgejo/runner#722
otherwise LGTM
@ -403,2 +403,4 @@}func sanitizeNetworkAlias(ctx context.Context, original string) string {logger := common.Logger(ctx)I would move this inside the if condition for performance reasons
6960e67280..0969687bf3@ -404,1 +404,4 @@func sanitizeNetworkAlias(ctx context.Context, original string) string {logger := common.Logger(ctx)sanitized := regexp.MustCompile("[^A-Z0-9-]").ReplaceAllString(strings.ToUpper(original), "_")shouldn't we store the regex statically for performance?
Agreed on both: it keeps the footprint of this change to a minimum.
6960e67280..0969687bf36960e672800969687bf3cascading-pr updated at forgejo/runner#722