forgejo/act
Archived
24
5
Fork 16
Code Issues Pull requests Releases Activity Actions

feat: use hashed uses string as cache dir name #186

Merged
earl-warren merged 1 commit from earl-warren/act:wip-cache into main 2025-07-21 21:08:46 +00:00
Conversation 12 Commits 1 Files changed 4 +49 -6
earl-warren commented 2025-07-16 10:11:31 +00:00
Contributor
Copy link

Port of https://gitea.com/gitea/act/pulls/117

Refs forgejo/act#100

Port of https://gitea.com/gitea/act/pulls/117 Refs forgejo/act#100
earl-warren changed title from feat: use hashed uses string as cache dir name [skip cascade] to feat: use hashed uses string as cache dir name 2025-07-16 10:23:23 +00:00
earl-warren force-pushed wip-cache from e7fe6e6506
All checks were successful
/ cascade (pull_request_target) Has been skipped
Details
checks / unit (pull_request) Successful in 3m16s
Details
checks / integration (pull_request) Successful in 2m26s
Details
to 3d24c010bc
Some checks failed
checks / unit (pull_request) Successful in 4m50s
Details
checks / integration (pull_request) Successful in 3m8s
Details
/ cascade (pull_request_target) Failing after 12m49s
Details
2025-07-16 10:23:29 +00:00 Compare
cascading-pr commented 2025-07-16 10:25:04 +00:00
Contributor
Copy link

cascading-pr updated at forgejo/runner#713

cascading-pr updated at https://code.forgejo.org/forgejo/runner/pulls/713
viceice approved these changes 2025-07-16 11:21:37 +00:00
viceice left a comment
Owner

we probably should drop safeFilename and always use hashed folders?

we probably should drop `safeFilename` and always use hashed folders?
viceice commented 2025-07-16 11:22:28 +00:00
Owner
Copy link
# runner.forgejo.org/internal/app/run
internal/app/run/workflow.go:18:38: not enough arguments in call to model.ReadWorkflow
	have (*bytes.Reader)
	want (io.Reader, bool)
# runner.forgejo.org/internal/app/run
# [runner.forgejo.org/internal/app/run]
vet: internal/app/run/workflow.go:18:75: not enough arguments in call to model.ReadWorkflow
	have (*bytes.Reader)
	want (io.Reader, bool)
make: *** [Makefile:114: vet] Error 1

https://code.forgejo.org/forgejo/runner/actions/runs/4759/jobs/0#jobstep-4-92

``` # runner.forgejo.org/internal/app/run internal/app/run/workflow.go:18:38: not enough arguments in call to model.ReadWorkflow have (*bytes.Reader) want (io.Reader, bool) # runner.forgejo.org/internal/app/run # [runner.forgejo.org/internal/app/run] vet: internal/app/run/workflow.go:18:75: not enough arguments in call to model.ReadWorkflow have (*bytes.Reader) want (io.Reader, bool) make: *** [Makefile:114: vet] Error 1 ``` https://code.forgejo.org/forgejo/runner/actions/runs/4759/jobs/0#jobstep-4-92
earl-warren commented 2025-07-16 12:18:35 +00:00
Author
Contributor
Copy link

I will re-push once forgejo/runner#714 lands, until then it blocks cascades.

I will re-push once https://code.forgejo.org/forgejo/runner/pulls/714 lands, until then it blocks cascades.
👍 1
earl-warren commented 2025-07-16 12:19:35 +00:00
Author
Contributor
Copy link

@viceice wrote in #186 (comment):

we probably should drop safeFilename and always use hashed folders?

It is still used in the code dealing with re-usable workflows. This code needs work but it is a new feature as it does not work yet in Forgejo. And the change is not trivial.

@viceice wrote in https://code.forgejo.org/forgejo/act/pulls/186#issuecomment-47754: > we probably should drop `safeFilename` and always use hashed folders? It is still used in the code dealing with re-usable workflows. This code needs work but it is a new feature as it does not work yet in Forgejo. And the change is not trivial.
viceice commented 2025-07-16 12:34:22 +00:00
Owner
Copy link

@earl-warren wrote in #186 (comment):

@viceice wrote in #186 (comment):

we probably should drop safeFilename and always use hashed folders?

It is still used in the code dealing with re-usable workflows. This code needs work but it is a new feature as it does not work yet in Forgejo. And the change is not trivial.

i know. it was ment to remeber to do that

@earl-warren wrote in https://code.forgejo.org/forgejo/act/pulls/186#issuecomment-47784: > @viceice wrote in #186 (comment): > > > we probably should drop `safeFilename` and always use hashed folders? > > It is still used in the code dealing with re-usable workflows. This code needs work but it is a new feature as it does not work yet in Forgejo. And the change is not trivial. i know. it was ment to remeber to do that
cascading-pr commented 2025-07-16 16:03:12 +00:00
Contributor
Copy link

cascading-pr updated at forgejo/runner#715

cascading-pr updated at https://code.forgejo.org/forgejo/runner/pulls/715
earl-warren scheduled this pull request to auto merge when all checks succeed 2025-07-16 16:16:22 +00:00
cascading-pr commented 2025-07-21 15:44:14 +00:00
Contributor
Copy link

cascading-pr updated at forgejo/runner#715

cascading-pr updated at https://code.forgejo.org/forgejo/runner/pulls/715
earl-warren force-pushed wip-cache from 3d24c010bc
Some checks failed
checks / unit (pull_request) Successful in 4m50s
Details
checks / integration (pull_request) Successful in 3m8s
Details
/ cascade (pull_request_target) Failing after 12m49s
Details
to 68a435ef0a
Some checks failed
checks / unit (pull_request) Successful in 2m19s
Details
checks / integration (pull_request) Successful in 2m18s
Details
/ cascade (pull_request_target) Failing after 26s
Details
2025-07-21 16:03:41 +00:00 Compare
cascading-pr commented 2025-07-21 16:04:40 +00:00
Contributor
Copy link

cascading-pr updated at forgejo/runner#719

cascading-pr updated at https://code.forgejo.org/forgejo/runner/pulls/719
earl-warren commented 2025-07-21 16:59:11 +00:00
Author
Contributor
Copy link
forgejo-runner.log:[/test]   ✅  Success - Main FORGEJO_ACTION_REPOSITORY
forgejo-runner.log:[/test] ⭐ Run Main FORGEJO_ACTION_PATH
forgejo-runner.log:[/test]   🐳  docker exec cmd=[bash --noprofile --norc -e -o pipefail /var/run/act/workflow/3-composite-1.sh] user= workdir=
forgejo-runner.log:[/test]   | + [[ /var/run/act/actions/d3/94353f2e76d50c5b7adfe573adfbd278faec6560412537b2e63a3bb880f5ce =~ action-for-context@main$ ]]
forgejo-runner.log:[/test]   ❌  Failure - Main FORGEJO_ACTION_PATH
forgejo-runner.log:[/test] exitcode '1': failure

The end-to-end assumptions have to be modified.

``` forgejo-runner.log:[/test] ✅ Success - Main FORGEJO_ACTION_REPOSITORY forgejo-runner.log:[/test] ⭐ Run Main FORGEJO_ACTION_PATH forgejo-runner.log:[/test] 🐳 docker exec cmd=[bash --noprofile --norc -e -o pipefail /var/run/act/workflow/3-composite-1.sh] user= workdir= forgejo-runner.log:[/test] | + [[ /var/run/act/actions/d3/94353f2e76d50c5b7adfe573adfbd278faec6560412537b2e63a3bb880f5ce =~ action-for-context@main$ ]] forgejo-runner.log:[/test] ❌ Failure - Main FORGEJO_ACTION_PATH forgejo-runner.log:[/test] exitcode '1': failure ``` The end-to-end assumptions have to be modified.
earl-warren commented 2025-07-21 17:20:15 +00:00
Author
Contributor
Copy link

Waiting on forgejo/end-to-end#823 to be merged to change end-to-end testing assumptions on the forgejo action path.

Waiting on https://code.forgejo.org/forgejo/end-to-end/pulls/823 to be merged to change end-to-end testing assumptions on the forgejo action path.
cascading-pr commented 2025-07-21 20:33:08 +00:00
Contributor
Copy link

cascading-pr updated at forgejo/runner#719

cascading-pr updated at https://code.forgejo.org/forgejo/runner/pulls/719
earl-warren deleted branch wip-cache 2025-07-21 21:08:46 +00:00
Commenting is not possible because the repository is archived.
Reviewers
No reviewers
viceice
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind
Chore
Housekeeping, cleanup and chores

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind
Chore
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
earl-warren
3 participants
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
forgejo/act!186
No description provided.