forgejo/act
Archived
24
5
Fork 16
Code Issues Pull requests Releases Activity Actions

fix: allow overriding RUNNER_TOOL_CACHE from the config file #178

Merged
earl-warren merged 1 commit from earl-warren/act:wip-toolcache into main 2025-07-13 21:55:02 +00:00
Conversation 5 Commits 1 Files changed 9 +39 -9
earl-warren commented 2025-07-13 14:35:28 +00:00
Contributor
Copy link
  • rc.getToolCache(ctx) is used to figure out RUNNER_TOOL_CACHE and returns RUNNER_TOOL_CACHE if it is found in the runner config, e.g. 
    container:
  env:
    RUNNER_TOOL_CACHE: /srv/toolcache
  • store the value in the new toolCache data member for containers, in the same way it is done for host
  • GetRunnerContext for containers return toolCache instead of a hard coded string
  • add integration test

Closes forgejo/runner#184

- rc.getToolCache(ctx) is used to figure out RUNNER_TOOL_CACHE and returns RUNNER_TOOL_CACHE if it is found in the runner config, e.g. ```yaml container: env: RUNNER_TOOL_CACHE: /srv/toolcache ``` - store the value in the new `toolCache` data member for containers, in the same way it is done for host - GetRunnerContext for containers return `toolCache` instead of a hard coded string - add integration test Closes forgejo/runner#184
earl-warren changed title from WIP: fix: allow overriding RUNNER_TOOL_CACHE from the config file [skip cascade] to WIP: fix: allow overriding RUNNER_TOOL_CACHE from the config file 2025-07-13 14:42:02 +00:00
earl-warren force-pushed wip-toolcache from c7ccc99e6a
All checks were successful
/ cascade (pull_request_target) Has been skipped
Details
checks / unit (pull_request) Successful in 1m53s
Details
checks / integration (pull_request) Successful in 1m22s
Details
to 82906b6dbb
All checks were successful
checks / unit (pull_request) Successful in 1m10s
Details
checks / integration (pull_request) Successful in 1m3s
Details
/ cascade (pull_request_target) Successful in 35m12s
Details
2025-07-13 14:42:09 +00:00 Compare
cascading-pr commented 2025-07-13 14:43:04 +00:00
Contributor
Copy link

cascading-pr updated at forgejo/runner#694

cascading-pr updated at https://code.forgejo.org/forgejo/runner/pulls/694
earl-warren changed title from WIP: fix: allow overriding RUNNER_TOOL_CACHE from the config file to WIP: fix: allow overriding RUNNER_TOOL_CACHE from the config file [skip cascade] 2025-07-13 15:05:48 +00:00
earl-warren force-pushed wip-toolcache from 82906b6dbb
All checks were successful
checks / unit (pull_request) Successful in 1m10s
Details
checks / integration (pull_request) Successful in 1m3s
Details
/ cascade (pull_request_target) Successful in 35m12s
Details
to f8c87e1617
All checks were successful
/ cascade (pull_request_target) Has been skipped
Details
checks / unit (pull_request) Successful in 1m13s
Details
checks / integration (pull_request) Successful in 1m12s
Details
2025-07-13 15:05:56 +00:00 Compare
earl-warren changed title from WIP: fix: allow overriding RUNNER_TOOL_CACHE from the config file [skip cascade] to fix: allow overriding RUNNER_TOOL_CACHE from the config file [skip cascade] 2025-07-13 15:06:20 +00:00
earl-warren changed title from fix: allow overriding RUNNER_TOOL_CACHE from the config file [skip cascade] to fix: allow overriding RUNNER_TOOL_CACHE from the config file 2025-07-13 15:12:36 +00:00
viceice approved these changes 2025-07-13 15:43:27 +00:00
Dismissed
earl-warren force-pushed wip-toolcache from f8c87e1617
All checks were successful
/ cascade (pull_request_target) Has been skipped
Details
checks / unit (pull_request) Successful in 1m13s
Details
checks / integration (pull_request) Successful in 1m12s
Details
to f49b40b0ac
Some checks failed
checks / unit (pull_request) Successful in 1m21s
Details
checks / integration (pull_request) Successful in 1m15s
Details
/ cascade (pull_request_target) Failing after 36s
Details
2025-07-13 16:03:51 +00:00 Compare
earl-warren dismissed viceice's review 2025-07-13 16:03:52 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

earl-warren commented 2025-07-13 16:04:35 +00:00
Author
Contributor
Copy link

Just rebased, no change. An extra run of test won't hurt before merging 😇

Just rebased, no change. An extra run of test won't hurt before merging 😇
cascading-pr commented 2025-07-13 16:04:49 +00:00
Contributor
Copy link

cascading-pr updated at forgejo/runner#694

cascading-pr updated at https://code.forgejo.org/forgejo/runner/pulls/694
earl-warren scheduled this pull request to auto merge when all checks succeed 2025-07-13 16:05:01 +00:00
earl-warren deleted branch wip-toolcache 2025-07-13 21:55:03 +00:00
viceice approved these changes 2025-07-14 04:56:32 +00:00
Commenting is not possible because the repository is archived.
Reviewers
No reviewers
Maks1mS
viceice
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind
Chore
Housekeeping, cleanup and chores

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind
Chore
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
earl-warren
3 participants
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
forgejo/act!178
No description provided.