fix: do not fail the job when if: false #172
Kwonunn
viceice
Labels
No labels
Compat/Breaking
Kind/Bug
Kind
Chore
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
3 participants
No due date set.
Dependencies
No dependencies set.
Reference
forgejo/act!172
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "earl-warren/act:wip-job-result"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
v6.4.0 regression introduced in
dfeca80872It did not fail a test because the original fix has tests only for the case where a step is skipped, not when a job is skipped.
Closes forgejo/runner#660
cascading-pr updated at forgejo/runner#670
Updated the release notes at forgejo/runner#636/files accordingly.
ifcondition evaluates to false [v6.4.0] #660fix: do not fail the job whento fix: do not fail the job whenif: falseif: false[skip cascade]b015759e981d2d808981fix: do not fail the job whento fix: do not fail the job whenif: false[skip cascade]if: falsetests added
i don't see a fix beside the log level change 🤔
@viceice wrote in #172 (comment):
The logs are used as a communication bus between ACT and the runner. This is quite unusual but it is what it is.
func (r *Reporter) Fire(entry *log.Entry) error {r.stateMu.Lock()defer r.stateMu.Unlock()log.WithFields(entry.Data).Trace(entry.Message)timestamp := entry.Timeif r.state.StartedAt == nil {r.state.StartedAt = timestamppb.New(timestamp)}stage := entry.Data["stage"]if stage != "Main" {if v, ok := entry.Data["jobResult"]; ok {if jobResult, ok := r.parseResult(v); ok {r.state.Result = jobResultr.state.StoppedAt = timestamppb.New(timestamp)