forgejo/act
Archived
24
5
Fork 16
Code Issues Pull requests Releases Activity Actions

[RDNF #21 updated] fix: make node tool non volatile (#2372) + added 'time import' #168

Merged
earl-warren merged 2 commits from :nif-fix-make-node-tool-non-volatile-6de25a53bcba30bda7014e3172a241e4e531d807 into main 2025-07-06 16:56:42 +00:00
Conversation 6 Commits 2 Files changed 9 +68 -24
achyrva commented 2025-07-03 12:27:43 +00:00
Contributor
Copy link

https://github.com/nektos/act/pull/2372

  • fix: make node tool non volatile
    Currently downgrading node via setup-node can break later actions

  • fix it and lookup on startup

  • fix problems

https://github.com/nektos/act/pull/2372 + fix: make node tool non volatile Currently downgrading node via setup-node can break later actions + fix it and lookup on startup + fix problems
cascading-pr commented 2025-07-03 12:28:35 +00:00
Contributor
Copy link

cascading-pr updated at forgejo/runner#654

cascading-pr updated at https://code.forgejo.org/forgejo/runner/pulls/654
achyrva force-pushed nif-fix-make-node-tool-non-volatile-6de25a53bcba30bda7014e3172a241e4e531d807 from 46d0e2eea3
All checks were successful
checks / unit (pull_request) Successful in 1m54s
Details
checks / integration (pull_request) Successful in 1m3s
Details
/ cascade (pull_request_target) Successful in 34m16s
Details
to bb075ab2b9
Some checks failed
checks / unit (pull_request) Successful in 1m14s
Details
checks / integration (pull_request) Successful in 1m22s
Details
/ cascade (pull_request_target) Failing after 29s
Details
2025-07-03 13:03:46 +00:00 Compare
cascading-pr commented 2025-07-03 13:04:41 +00:00
Contributor
Copy link

cascading-pr updated at forgejo/runner#654

cascading-pr updated at https://code.forgejo.org/forgejo/runner/pulls/654
earl-warren commented 2025-07-05 14:33:02 +00:00
Contributor
Copy link

Closing this until the discussion on how to approach catching up with ACT concludes. It can be re-opened when a strategy was decided but in the meantime please @achyrva refrain from opening new ones.

Closing this until [the discussion on how to approach catching up with ACT concludes](https://code.forgejo.org/forgejo/act/issues/124#issuecomment-44558). It can be re-opened when a strategy was decided but in the meantime please @achyrva refrain from opening new ones.
earl-warren closed this pull request 2025-07-05 14:33:02 +00:00
earl-warren reopened this pull request 2025-07-06 16:34:54 +00:00
earl-warren approved these changes 2025-07-06 16:35:02 +00:00
Dismissed
earl-warren scheduled this pull request to auto merge when all checks succeed 2025-07-06 16:39:29 +00:00
earl-warren canceled auto merging this pull request when all checks succeed 2025-07-06 16:56:14 +00:00
earl-warren dismissed earl-warren's review 2025-07-06 16:56:19 +00:00
Reason:

test

earl-warren scheduled this pull request to auto merge when all checks succeed 2025-07-06 16:56:29 +00:00
earl-warren deleted branch nif-fix-make-node-tool-non-volatile-6de25a53bcba30bda7014e3172a241e4e531d807 2025-07-06 16:56:42 +00:00
viceice reviewed 2025-07-06 17:18:03 +00:00
pkg/runner/action.go
@ -571,4 +570,1 @@
var containerArgs []string
if action.Runs.Using == model.ActionRunsUsingSh {
viceice commented 2025-07-06 17:18:03 +00:00
Owner

why this if condition was dropped? doesn't it break something 🤔

why this if condition was dropped? doesn't it break something 🤔
earl-warren commented 2025-07-06 20:26:16 +00:00
Contributor

Good catch, it is not part of the original commit. I reviewed the original commit because there was no indication of conflict in !168 (commit c1a1722cbe)

And I missed they are actually different.

I'll revert that now.

Good catch, it is not part of the original commit. I reviewed the original commit because there was no indication of conflict in https://code.forgejo.org/forgejo/act/pulls/168/commits/c1a1722cbe5b4f21ab57952647509827eeec955e And I missed they are actually different. I'll revert that now.
earl-warren commented 2025-07-06 20:27:49 +00:00
Contributor

dd138c24f8

https://code.forgejo.org/forgejo/act/commit/dd138c24f8893f60a421c86a4f650f8cbaf08efc
earl-warren marked this conversation as resolved
Commenting is not possible because the repository is archived.
Reviewers
No reviewers
earl-warren
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind
Chore
Housekeeping, cleanup and chores

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind
Chore
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
forgejo/act!168
No description provided.