forgejo/act
Archived
24
5
Fork 16
Code Issues Pull requests Releases Activity Actions

[RDNF #11] fix: skipped jobs have no result & fix: favor command-line over files & chore: fix some comments #143

Merged
earl-warren merged 3 commits from :nektos-into-forgejo-7 into main 2025-06-09 10:25:44 +00:00
Conversation 5 Commits 3 Files changed 4 +8 -5
achyrva commented 2025-06-09 09:44:24 +00:00
Contributor
Copy link

https://github.com/nektos/act/pull/2274
https://github.com/nektos/act/pull/2276
https://github.com/nektos/act/pull/2279

https://github.com/nektos/act/pull/2274 https://github.com/nektos/act/pull/2276 https://github.com/nektos/act/pull/2279 
Signed-off-by: lvyaoting <[email protected]>
Co-authored-by: ChristopherHX <[email protected]>
This impacts:
- envs
- inputs
- secrets
- vars
merge skipping jobs have no results
Some checks failed
checks / unit (pull_request) Successful in 2m55s
Details
checks / integration (pull_request) Successful in 1m23s
Details
/ cascade (pull_request_target) Failing after 29s
Details
8d0747cbe1
cascading-pr commented 2025-06-09 09:45:34 +00:00
Contributor
Copy link

cascading-pr updated at forgejo/runner#597

cascading-pr updated at https://code.forgejo.org/forgejo/runner/pulls/597
earl-warren commented 2025-06-09 09:57:33 +00:00
Contributor
Copy link

Note to self: technically https://github.com/nektos/act/pull/2274 is a breaking change but this fork of ACT makes no promise yet regarding breaking changes and IMHO the odds that someone notices are extremely low to non-existent. They would have to be in a situation where they are used to files overriding CLI argument, which I doubt ever happens.

Note to self: technically https://github.com/nektos/act/pull/2274 is a breaking change but this fork of ACT makes no promise yet regarding breaking changes and IMHO the odds that someone notices are extremely low to non-existent. They would have to be in a situation where they are used to files overriding CLI argument, which I doubt ever happens.
earl-warren scheduled this pull request to auto merge when all checks succeed 2025-06-09 09:57:46 +00:00
earl-warren deleted branch nektos-into-forgejo-7 2025-06-09 10:25:44 +00:00
earl-warren commented 2025-07-07 09:14:35 +00:00
Contributor
Copy link

I entirely missed the regression introduced in !143 (commit 8d0747cbe1) which is different from the commit it cherry-picked https://github.com/nektos/act/pull/2276/files because of an unmarked conflict resolution.

In the end this is my responsibility as a reviewer but yet another example of why it is important to document conflict resolution: they may have a high impact.

I entirely missed the regression introduced in https://code.forgejo.org/forgejo/act/pulls/143/commits/8d0747cbe1ea0def25b381e2ec8caeb5fafb9394 which is different from the commit it cherry-picked https://github.com/nektos/act/pull/2276/files because of an unmarked conflict resolution. In the end this is my responsibility as a reviewer but yet another example of why it is important to document conflict resolution: they may have a high impact.
earl-warren commented 2025-07-07 09:15:52 +00:00
Contributor
Copy link

Regression fixed at #172

Regression fixed at https://code.forgejo.org/forgejo/act/pulls/172
Commenting is not possible because the repository is archived.
Reviewers
No reviewers
earl-warren
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind
Chore
Housekeeping, cleanup and chores

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind
Chore
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
forgejo/act!143
No description provided.