forgejo/act
Archived
24
5
Fork 16
Code Issues Pull requests Releases Activity Actions

fix: artifacts/server: properly format IP/port for listen address #135

Merged
earl-warren merged 1 commit from :fix-artifact-ip into main 2025-06-09 09:01:40 +00:00
Conversation 10 Commits 1 Files changed 3 +41 -5
c8h4 commented 2025-05-24 11:04:27 +00:00
Member
Copy link

Hi!

This primarily fixes the listen address for the artifact server - currently, if an plain IPv6 address is passed (e.g. 2001:db8::1), it results in 2001:db::1:3456 as the formatted address.

It also this changes so that artifactServerAddr is represented as a net.IP and artifactServerPort as uint16, thus making the whole thing a bit more typesafe.
As the latter breaks the API for config.Runner (by changing the struct field types), I hope this is okay - otherwise, I'll just drop the commit if compatibility is more desired. done.
The corresponding runner PR: forgejo/runner#576

Hi! This primarily fixes the listen address for the artifact server - currently, if an plain IPv6 address is passed (e.g. `2001:db8::1`), it results in `2001:db::1:3456` as the formatted address. ~~It also this changes so that `artifactServerAddr` is represented as a `net.IP` and `artifactServerPort` as `uint16`, thus making the whole thing a bit more typesafe. As the latter breaks the API for `config.Runner` (by changing the struct field types), I hope this is okay - otherwise, I'll just drop the commit if compatibility is more desired.~~ done. The corresponding runner PR: https://code.forgejo.org/forgejo/runner/pulls/576
earl-warren requested changes 2025-05-25 06:46:14 +00:00
Dismissed
earl-warren left a comment
Contributor

Good fix 👍

The runner makes no promise regarding backward compatibility, the amount of work required to change the type of the fields is going to be a burden immediately and only brings marginal benefits.

I think it is best to keep it in another pull request, separated from the bug fix.

Good fix 👍 The runner makes no promise regarding backward compatibility, the amount of work required to change the type of the fields is going to be a burden immediately and only brings marginal benefits. I think it is best to keep it in another pull request, separated from the bug fix.
earl-warren changed title from fix: artifacts/server: properly format IP/port for listen address to fix: artifacts/server: properly format IP/port for listen address [skip cascade] 2025-05-25 06:51:44 +00:00
earl-warren commented 2025-05-25 06:51:50 +00:00
Contributor
Copy link

Marking as [skip cascade] so that it does not trigger the full test suite until it is ready to succeed.

Marking as [skip cascade] so that it does not trigger the full test suite until it is ready to succeed.
earl-warren reviewed 2025-05-25 06:52:49 +00:00
pkg/artifactcache/handler.go Outdated
@ -120,2 +121,2 @@
h.outboundIP,
h.listener.Addr().(*net.TCPAddr).Port)
return fmt.Sprintf("http://%s",
net.JoinHostPort(h.outboundIP, strconv.FormatUint(uint64(port), 10)),
earl-warren commented 2025-05-25 06:52:49 +00:00
Contributor

Could you please find where this should be tested and add a testcase?

Could you please find where this should be tested and add a testcase?
c8h4 commented 2025-05-25 12:58:59 +00:00
Author
Member

Done. Not really familiar with the go unit testing framework, so please do not hestitate if there are better ways to do things.

Done. Not really familiar with the go unit testing framework, so please do not hestitate if there are better ways to do things.
c8h4 marked this conversation as resolved
c8h4 commented 2025-05-25 12:27:32 +00:00
Author
Member
Copy link

The runner makes no promise regarding backward compatibility, the amount of work required to change the type of the fields is going to be a burden immediately and only brings marginal benefits.

I think it is best to keep it in another pull request, separated from the bug fix.

Right, I'll just drop that change. 👍

> The runner makes no promise regarding backward compatibility, the amount of work required to change the type of the fields is going to be a burden immediately and only brings marginal benefits. > > I think it is best to keep it in another pull request, separated from the bug fix. Right, I'll just drop that change. 👍
c8h4 force-pushed fix-artifact-ip from 7fb03fd711
Some checks failed
/ cascade (pull_request_target) Failing after 1m29s
Details
checks / unit (pull_request) Failing after 2m0s
Details
checks / integration (pull_request) Has been skipped
Details
to 74ed568cb9
Some checks failed
/ cascade (pull_request_target) Has been skipped
Details
checks / integration (pull_request) Has been cancelled
Details
checks / unit (pull_request) Has been cancelled
Details
2025-05-25 12:45:53 +00:00 Compare
c8h4 force-pushed fix-artifact-ip from 74ed568cb9
Some checks failed
/ cascade (pull_request_target) Has been skipped
Details
checks / integration (pull_request) Has been cancelled
Details
checks / unit (pull_request) Has been cancelled
Details
to 9d57dc9ba1
Some checks failed
/ cascade (pull_request_target) Has been skipped
Details
checks / unit (pull_request) Failing after 1m48s
Details
checks / integration (pull_request) Has been skipped
Details
2025-05-25 12:58:01 +00:00 Compare
c8h4 force-pushed fix-artifact-ip from 9d57dc9ba1
Some checks failed
/ cascade (pull_request_target) Has been skipped
Details
checks / unit (pull_request) Failing after 1m48s
Details
checks / integration (pull_request) Has been skipped
Details
to 3fbcc2c7ef
All checks were successful
/ cascade (pull_request_target) Has been skipped
Details
checks / unit (pull_request) Successful in 2m50s
Details
checks / integration (pull_request) Successful in 56s
Details
2025-05-25 17:16:22 +00:00 Compare
earl-warren requested changes 2025-05-26 05:19:50 +00:00
Dismissed
pkg/artifacts/server.go Outdated
@ -299,3 +300,3 @@
// run server
go func() {
logger.Infof("Start server on http://%s:%s", addr, port)
logger.Infof("Start server on http://%s", server.Addr)
earl-warren commented 2025-05-26 05:19:47 +00:00
Contributor

Port is missing here.

Port is missing here.
c8h4 commented 2025-06-01 10:09:12 +00:00
Author
Member

http.Addr is set to the correct host:port string above, so this just reuses that.
But if you want I can change that.

`http.Addr` is set to the correct `host:port` string above, so this just reuses that. But if you want I can change that.
earl-warren changed title from fix: artifacts/server: properly format IP/port for listen address [skip cascade] to fix: artifacts/server: properly format IP/port for listen address 2025-05-26 05:20:02 +00:00
earl-warren commented 2025-05-26 05:20:42 +00:00
Contributor
Copy link

Could you please update the title to reflect the current state of the PR? chore:...

Could you please update the title to reflect the current state of the PR? `chore:...`
c8h4 commented 2025-06-01 10:09:47 +00:00
Author
Member
Copy link

@earl-warren wrote in #135 (comment):

Could you please update the title to reflect the current state of the PR? chore:...

I mean, it still fixes original problem, no?

@earl-warren wrote in https://code.forgejo.org/forgejo/act/pulls/135#issuecomment-40888: > Could you please update the title to reflect the current state of the PR? `chore:...` I mean, it still fixes original problem, no?
c8h4 force-pushed fix-artifact-ip from 3fbcc2c7ef
All checks were successful
/ cascade (pull_request_target) Has been skipped
Details
checks / unit (pull_request) Successful in 2m50s
Details
checks / integration (pull_request) Successful in 56s
Details
to 31d7feaeb0
Some checks failed
checks / unit (pull_request) Successful in 1m7s
Details
checks / integration (pull_request) Successful in 42s
Details
/ cascade (pull_request_target) Failing after 1m40s
Details
2025-06-01 10:11:08 +00:00 Compare
cascading-pr commented 2025-06-01 10:12:00 +00:00
Contributor
Copy link

cascading-pr updated at forgejo/runner#587

cascading-pr updated at https://code.forgejo.org/forgejo/runner/pulls/587
earl-warren commented 2025-06-09 09:01:35 +00:00
Contributor
Copy link

Thanks for the gentle ping 😊

Thanks for the gentle ping 😊
❤️ 1
earl-warren deleted branch fix-artifact-ip 2025-06-09 09:01:40 +00:00
Commenting is not possible because the repository is archived.
Reviewers
No reviewers
earl-warren
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind
Chore
Housekeeping, cleanup and chores

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind
Chore
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
forgejo/act!135
No description provided.