forgejo/act
Archived
24
5
Fork 16
Code Issues Pull requests Releases Activity Actions

feat: add node as shell type #120

Merged
earl-warren merged 2 commits from Maks1mS/act:feat/node-as-shell-type into main 2025-05-26 05:13:07 +00:00
Conversation 7 Commits 2 Files changed 4 +31
Maks1mS commented 2025-04-18 15:16:21 +00:00
Member
Copy link
No description provided.
feat: add node as shell type
All checks were successful
/ cascade (pull_request_target) Successful in 34m29s
Details
checks / unit (pull_request) Successful in 1m11s
Details
checks / integration (pull_request) Successful in 25s
Details
07a5358b47
cascading-pr commented 2025-04-18 15:17:06 +00:00
Contributor
Copy link

cascading-pr updated at forgejo/runner#543

cascading-pr updated at https://code.forgejo.org/forgejo/runner/pulls/543
earl-warren changed title from feat: add node as shell type to feat: add node as shell type [skip cascade] 2025-04-18 18:59:18 +00:00
earl-warren commented 2025-04-18 19:02:34 +00:00
Contributor
Copy link

This is looking good 👍 Can you please confirm that the test is run in the CI?

This is looking good 👍 Can you please confirm that the test is run in the CI?
earl-warren commented 2025-04-18 19:04:46 +00:00
Contributor
Copy link

https://code.forgejo.org/forgejo/act/actions/runs/616/jobs/0#jobstep-10-311 it should be around here but I don't see it. What am I missing?

https://code.forgejo.org/forgejo/act/actions/runs/616/jobs/0#jobstep-10-311 it should be around here but I don't see it. What am I missing?
Maks1mS commented 2025-04-18 19:25:57 +00:00
Author
Member
Copy link

@earl-warren wrote in #120 (comment):

https://code.forgejo.org/forgejo/act/actions/runs/616/jobs/0#jobstep-10-311 it should be around here but I don't see it. What am I missing?

It looks like I have to fix it here.

Lines 505 to 520 in af28212
func TestStep_ShellCommand(t *testing.T) {
tests := []struct {
shell string
want string
}{
{"pwsh -v '. {0}'", "pwsh -v '. {0}'"},
{"pwsh", "pwsh -command . '{0}'"},
{"powershell", "powershell -command . '{0}'"},
}
for _, tt := range tests {
t.Run(tt.shell, func(t *testing.T) {
got := (&Step{Shell: tt.shell}).ShellCommand()
assert.Equal(t, got, tt.want)
})
}
}

I acted by analogy with the python shell, but it's not here. I can add it too.

@earl-warren wrote in https://code.forgejo.org/forgejo/act/pulls/120#issuecomment-38002: > https://code.forgejo.org/forgejo/act/actions/runs/616/jobs/0#jobstep-10-311 it should be around here but I don't see it. What am I missing? It looks like I have to fix it here. https://code.forgejo.org/forgejo/act/src/commit/af28212d7052afec0bf70d3c84da54c3fcebb4e9/pkg/model/workflow_test.go#L505-L520 I acted by analogy with the python shell, but it's not here. I can add it too.
👍 1
tests: add node and python in TestStep_ShellCommand
Some checks failed
checks / unit (pull_request) Successful in 50s
Details
checks / integration (pull_request) Successful in 24s
Details
/ cascade (pull_request_target) Failing after 24s
Details
4d3fcbc4c2
viceice approved these changes 2025-05-12 09:34:11 +00:00
limiting-factor changed title from feat: add node as shell type [skip cascade] to feat: add node as shell type 2025-05-13 07:21:20 +00:00
limiting-factor commented 2025-05-13 07:22:24 +00:00
Member
Copy link

The test ran successfully https://code.forgejo.org/forgejo/act/actions/runs/618/jobs/0#jobstep-10-315

The test ran successfully https://code.forgejo.org/forgejo/act/actions/runs/618/jobs/0#jobstep-10-315
earl-warren deleted branch feat/node-as-shell-type 2025-05-26 05:13:08 +00:00
Commenting is not possible because the repository is archived.
Reviewers
No reviewers
viceice
limiting-factor
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind
Chore
Housekeeping, cleanup and chores

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind
Chore
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
forgejo/act!120
No description provided.