forgejo/act
Archived
24
5
Fork 16
Code Issues Pull requests Releases Activity Actions

PR#3. Reducing the delta between Nektos/Act and Forgejo/Act #117

Merged
viceice merged 2 commits from :nektos-into-forgejo-0 into main 2025-04-16 10:54:48 +00:00
Conversation 11 Commits 2 Files changed 4 +110 -50
achyrva commented 2025-04-10 09:02:30 +00:00
Contributor
Copy link

Reducing the delta between Nektos/Act and Forgejo/Act

Cherry-pick of commits appropriate to following Nektos PR's:

Reducing the delta between Nektos/Act and Forgejo/Act Cherry-pick of commits appropriate to following Nektos PR's: - https://github.com/nektos/act/pull/2173 - https://github.com/nektos/act/pull/2208
👍 1
achyrva changed title from WIP: PR#3. Reducing the delta between Nektos/Act and Forgejo/Act [skip cascade] to PR#3. Reducing the delta between Nektos/Act and Forgejo/Act [skip cascade] 2025-04-10 09:05:51 +00:00
earl-warren commented 2025-04-10 09:27:21 +00:00
Contributor
Copy link

This is looking good, having those two commits together make sense.

This is looking good, having those two commits together make sense.
achyrva changed title from PR#3. Reducing the delta between Nektos/Act and Forgejo/Act [skip cascade] to PR#3. Reducing the delta between Nektos/Act and Forgejo/Act 2025-04-11 07:56:49 +00:00
achyrva commented 2025-04-11 08:01:32 +00:00
Author
Contributor
Copy link

@earl-warren wrote in #117 (comment):

This is looking good, having those two commits together make sense.

What should be done to get merge this PR?
@earl-warren

@earl-warren wrote in https://code.forgejo.org/forgejo/act/pulls/117#issuecomment-37469: > This is looking good, having those two commits together make sense. What should be done to get merge this PR? @earl-warren
earl-warren commented 2025-04-11 14:27:27 +00:00
Contributor
Copy link

Now that the unit & integration tests passed, you should rebase / amend and force push to trigger the cascading tests. They will run https://code.forgejo.org/forgejo/end-to-end.

Now that the unit & integration tests passed, you should rebase / amend and force push to trigger the cascading tests. They will run https://code.forgejo.org/forgejo/end-to-end.
achyrva force-pushed nektos-into-forgejo-0 from 2a5fe65149
All checks were successful
/ cascade (pull_request_target) Has been skipped
Details
checks / unit (pull_request) Successful in 1m33s
Details
checks / integration (pull_request) Successful in 50s
Details
to b1bd307c21
Some checks failed
checks / unit (pull_request) Successful in 50s
Details
checks / integration (pull_request) Successful in 26s
Details
/ cascade (pull_request_target) Failing after 51s
Details
2025-04-12 14:03:15 +00:00 Compare
cascading-pr commented 2025-04-12 14:04:12 +00:00
Contributor
Copy link

cascading-pr updated at forgejo/runner#538

cascading-pr updated at https://code.forgejo.org/forgejo/runner/pulls/538
earl-warren commented 2025-04-13 06:54:59 +00:00
Contributor
Copy link

That did not break anything, that's good 👍 Could you replace the title and description with something more descriptive please?

One would otherwise have to guess what this is about and also guess that the numbers at the end of the commit are related to the ACT repository on GitHub.

That did not break anything, that's good 👍 Could you replace the title and description with something more descriptive please? One would otherwise have to guess what this is about and also guess that the numbers at the end of the commit are related to the ACT repository on GitHub. - https://github.com/nektos/act/pull/2173 - https://github.com/nektos/act/pull/2208
achyrva commented 2025-04-16 10:16:34 +00:00
Author
Contributor
Copy link

@earl-warren
Could somebody merge this PR?

@earl-warren Could somebody merge this PR?
viceice approved these changes 2025-04-16 10:54:18 +00:00
viceice deleted branch nektos-into-forgejo-0 2025-04-16 10:54:48 +00:00
earl-warren commented 2025-04-16 13:40:33 +00:00
Contributor
Copy link

@achyrva could you please address this comment #117 (comment)?

@achyrva could you please address this comment https://code.forgejo.org/forgejo/act/pulls/117#issuecomment-37593?
achyrva commented 2025-04-16 13:56:41 +00:00
Author
Contributor
Copy link

@earl-warren wrote in #117 (comment):

@achyrva could you please address this comment #117 (comment)?

@earl-warren is something goes wrong?

@earl-warren wrote in https://code.forgejo.org/forgejo/act/pulls/117#issuecomment-37840: > @achyrva could you please address this comment #117 (comment)? @earl-warren is something goes wrong?
earl-warren commented 2025-04-16 16:43:52 +00:00
Contributor
Copy link

Could you replace the title and description with something more descriptive please?

One would otherwise have to guess what this is about and also guess that the numbers at the end of the commit are related to the ACT repository on GitHub.

Could you replace the title and description with something more descriptive please? One would otherwise have to guess what this is about and also guess that the numbers at the end of the commit are related to the ACT repository on GitHub. - https://github.com/nektos/act/pull/2173 - https://github.com/nektos/act/pull/2208
Commenting is not possible because the repository is archived.
Reviewers
No reviewers
earl-warren
viceice
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind
Chore
Housekeeping, cleanup and chores

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind
Chore
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
forgejo/act!117
No description provided.