forgejo/act
Archived
24
5
Fork 16
Code Issues Pull requests Releases Activity Actions

fix: ensure the LXC template does not have obsolete APT #102

Merged
earl-warren merged 2 commits from earl-warren/act:wip-apt-old into main 2025-01-29 10:02:37 +00:00
Conversation 10 Commits 2 Files changed 3 +134 -106
earl-warren commented 2025-01-28 23:24:31 +00:00
Contributor
Copy link

Includes an upgrade to https://code.forgejo.org/forgejo/lxc-helpers/src/tag/v1.0.3 which contains the foundations of this fix forgejo/lxc-helpers#31/files

The test verifying it actually works is at https://code.forgejo.org/forgejo/end-to-end/src/branch/main/actions/example-lxc

Includes an upgrade to https://code.forgejo.org/forgejo/lxc-helpers/src/tag/v1.0.3 which contains the foundations of this fix https://code.forgejo.org/forgejo/lxc-helpers/pulls/31/files The test verifying it actually works is at https://code.forgejo.org/forgejo/end-to-end/src/branch/main/actions/example-lxc
cascading-pr commented 2025-01-28 23:25:16 +00:00
Contributor
Copy link

cascading-pr updated at forgejo/runner#466

cascading-pr updated at https://code.forgejo.org/forgejo/runner/pulls/466
viceice reviewed 2025-01-29 05:25:13 +00:00
viceice left a comment
Owner

otherwise LGTM

otherwise LGTM
pkg/runner/lxc-helpers-lib.sh Outdated
@ -8,3 +8,3 @@
LXC_CONTAINER_CONFIG_ALL="unprivileged lxc libvirt docker k8s"
LXC_CONTAINER_CONFIG_DEFAULT="lxc libvirt docker"
LXC_IPV6_PREFIX_DEFAULT="fc15"
LXC_IPV6_PREFIX_DEFAULT="fd15"
viceice commented 2025-01-29 05:23:33 +00:00
Owner

why this? 🤔

why this? 🤔
earl-warren commented 2025-01-29 06:40:29 +00:00
Author
Contributor

forgejo/lxc-helpers#29

because I incorrectly thought fc was not a unique local address 🤔 My bad.

https://code.forgejo.org/forgejo/lxc-helpers/pulls/29 because I incorrectly thought fc was not a unique local address 🤔 My bad.
earl-warren commented 2025-01-29 07:44:38 +00:00
Author
Contributor

5430b01366..86fb21a205

https://code.forgejo.org/forgejo/act/compare/5430b01366f6786583d31936c43da9e7b880fc8c..86fb21a205fa0dae47dea7656c2f92c2988697cb
viceice commented 2025-01-29 07:59:36 +00:00
Owner
- #103
earl-warren marked this conversation as resolved
viceice approved these changes 2025-01-29 07:03:12 +00:00
Dismissed
viceice left a comment
Owner

why not simply call apt update when outdated?

why not simply call `apt update` when outdated?
earl-warren commented 2025-01-29 07:37:50 +00:00
Author
Contributor
Copy link

That was my first idea. But there may be more to keeping a template up to date than just apt. The motivation is apt being obsolete: it has caused actual breakage in the past. This solution also covers potential updates in other areas. I don't know if there are any and I'm happy not figuring that out.

In short this is a more general solution where APT is a sign of a template not being up to date and the solution is to re-create.

Does that sound sensible?

That was my first idea. But there may be more to keeping a template up to date than just apt. The motivation is apt being obsolete: it has caused actual breakage in the past. This solution also covers potential updates in other areas. I don't know if there are any and I'm happy not figuring that out. In short this is a more general solution where APT is a sign of a template not being up to date and the solution is to re-create. Does that sound sensible?
earl-warren force-pushed wip-apt-old from 5430b01366
All checks were successful
checks / unit (pull_request) Successful in 1m16s
Details
checks / integration (pull_request) Successful in 28s
Details
/ cascade (pull_request_target) Successful in 32m4s
Details
to 86fb21a205
All checks were successful
checks / unit (pull_request) Successful in 1m2s
Details
checks / integration (pull_request) Successful in 42s
Details
/ cascade (pull_request_target) Successful in 38m5s
Details
2025-01-29 07:44:01 +00:00 Compare
earl-warren dismissed viceice's review 2025-01-29 07:44:01 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

cascading-pr commented 2025-01-29 07:44:45 +00:00
Contributor
Copy link

cascading-pr updated at forgejo/runner#466

cascading-pr updated at https://code.forgejo.org/forgejo/runner/pulls/466
viceice approved these changes 2025-01-29 07:46:35 +00:00
Dismissed
viceice left a comment
Owner

makes sense.

you dropped the ipv6 change here?

makes sense. you dropped the ipv6 change here?
earl-warren commented 2025-01-29 08:06:02 +00:00
Author
Contributor
Copy link

@viceice wrote in #102 (comment):

makes sense.

you dropped the ipv6 change here?

Yes. And in lxc-helpers too, reverted.

@viceice wrote in https://code.forgejo.org/forgejo/act/pulls/102#issuecomment-31461: > makes sense. > > you dropped the ipv6 change here? Yes. And in lxc-helpers too, reverted.
viceice dismissed viceice's review 2025-01-29 08:29:17 +00:00
Reason:

Should not be merged as is

earl-warren changed title from fix: ensure the LXC template does not have obsolete APT to WIP: fix: ensure the LXC template does not have obsolete APT 2025-01-29 08:38:09 +00:00
earl-warren force-pushed wip-apt-old from 86fb21a205
All checks were successful
checks / unit (pull_request) Successful in 1m2s
Details
checks / integration (pull_request) Successful in 42s
Details
/ cascade (pull_request_target) Successful in 38m5s
Details
to 4b0aa114c6
Some checks failed
checks / unit (pull_request) Successful in 1m3s
Details
checks / integration (pull_request) Successful in 31s
Details
/ cascade (pull_request_target) Failing after 22s
Details
2025-01-29 09:30:19 +00:00 Compare
cascading-pr commented 2025-01-29 09:31:07 +00:00
Contributor
Copy link

cascading-pr updated at forgejo/runner#466

cascading-pr updated at https://code.forgejo.org/forgejo/runner/pulls/466
earl-warren commented 2025-01-29 09:32:37 +00:00
Author
Contributor
Copy link

86fb21a205..4b0aa114c6

switch back to using fd*

https://code.forgejo.org/forgejo/act/compare/86fb21a205fa0dae47dea7656c2f92c2988697cb..4b0aa114c685aed31d0038c110fc02a78bf02205 switch back to using fd*
earl-warren changed title from WIP: fix: ensure the LXC template does not have obsolete APT to fix: ensure the LXC template does not have obsolete APT 2025-01-29 09:32:44 +00:00
viceice approved these changes 2025-01-29 09:36:30 +00:00
earl-warren scheduled this pull request to auto merge when all checks succeed 2025-01-29 09:50:19 +00:00
earl-warren deleted branch wip-apt-old 2025-01-29 10:02:37 +00:00
Commenting is not possible because the repository is archived.
Reviewers
No reviewers
Kwonunn
viceice
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind
Chore
Housekeeping, cleanup and chores

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind
Chore
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
earl-warren
3 participants
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
forgejo/act!102
No description provided.