This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: urllib -- add_handler method refactoring for clarity
Type: enhancement Stage:
Components: Versions: Python 3.4
process
Status: closed Resolution: not a bug
Dependencies: Superseder:
Assigned To: Nosy List: Max.Mautner, r.david.murray
Priority: normal Keywords: patch

Created on 2013-04-13 21:17 by Max.Mautner, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
urllib_add_handler.patch Max.Mautner, 2013-04-13 21:17 patches urllib.request's add_handler review
Messages (2)
msg186853 - (view) Author: Max Mautner (Max.Mautner) * Date: 2013-04-13 21:17
Response handlers are registered with the OpenerDirector class in the urllib.request module using the add_handler method--it's a convoluted method that I refactored for legibility's sake.
msg187981 - (view) Author: R. David Murray (r.david.murray) * (Python committer) Date: 2013-04-28 14:11
I presume you closed this bug yourself because you decided it probably wasn't worth applying it?  I'm inclined to agree.  Cleaning up the code would be nice, but since the existing code works fine, changing it *just* to clean it up probably isn't worth the code churn or the chance of introducing an unexpected new bug.  

If we were also fixing a bug while doing the rewrite, it would be a different story.  So I'll try to keep this patch in mind if we have occasion to fix anything in that code.
History
Date User Action Args
2022-04-11 14:57:44adminsetgithub: 61924
2013-04-28 14:11:34r.david.murraysetnosy: + r.david.murray
messages: + msg187981
2013-04-17 13:24:53Max.Mautnersetstatus: open -> closed
resolution: not a bug
2013-04-13 21:17:28Max.Mautnercreate