Skip to:
Content

BuddyPress.org

Opened 9 years ago

Closed 7 years ago

#7533 closed enhancement (fixed)

needs a filter on group and activity list table sortable columns

Reported by: modemlooper's profile modemlooper Owned by: espellcaste's profile espellcaste
Milestone: 5.0.0 Priority: low
Severity: trivial Version: 2.8.2
Component: Core Keywords: good-first-bug has-patch
Cc:

Description

You can add columns but get_sortable_columns isn't filterable to add your new columns.

​https://buddypress.trac.wordpress.org/browser/trunk/src/bp-groups/classes/class-bp-groups-list-table.php#L419

​https://buddypress.trac.wordpress.org/browser/trunk/src/bp-activity/classes/class-bp-activity-list-table.php#L394

Attachments (1)

7533.diff​ (3.9 KB) - added by espellcaste 7 years ago.

Download all attachments as: .zip

Change History (5)

#1 @DJPaul
9 years ago

  • Keywords good-first-bug added
  • Milestone changed from Awaiting Review to Future Release

#2 @espellcaste
7 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Contributions to 5.0.0
  • Owner set to espellcaste
  • Status changed from new to accepted

This is something we can do at the next milestone.

@espellcaste
7 years ago

#3 @espellcaste
7 years ago

  • Keywords has-patch added; needs-patch removed

Implementation adds the necessary hooks to add or change the columns names. Irrelevant comments were removed as well.

A new set of eyes would be helpful! :)

Last edited 7 years ago by espellcaste (previous) (diff)

#4 @espellcaste
7 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 12331:

Added hooks to filter Activity and Groups list table get_sortable_columns

Adding custom hooks permitting the sortable columns of the Activity and Group list table to be filtered.

Props @modemlooper
Fixes #7533

Note: See TracTickets for help on using tickets.