Changeset 14174

Timestamp:

12/26/2025 07:51:49 PM (8 weeks ago)

Author:

espellcaste

Message:

Restore no-js body class for BuddyPress pages.

Regression introduced at [13672], part of [13418].

Props r-a-y and vapvarun.

See #8679
See #9304 (14.0)

Location:

branches/14.0/src/bp-templates

Files:

• bp-legacy/buddypress-functions.php (modified) (3 diffs)
• bp-nouveau/buddypress-functions.php (modified) (2 diffs)

branches/14.0/src/bp-templates/bp-legacy/buddypress-functions.php

@@ -85 +85 @@
         add_action( 'bp_enqueue_community_scripts', array( $this, 'localize_scripts' ) ); // Enqueue theme script localization
 
-        /** This filter is documented in bp-core/bp-core-dependency.php */
-        if ( is_buddypress() || ! apply_filters( 'bp_enqueue_assets_in_bp_pages_only', true ) ) {
-            // Body no-js class.
-            add_filter( 'body_class', array( $this, 'add_nojs_body_class' ), 20, 1 );
-        }
+        // Body no-js class.
+        add_filter( 'body_class', array( $this, 'add_nojs_body_class' ), 20, 1 );
 
         /** Buttons ***********************************************************/
@@ -476 +473 @@
      * @since 1.7.0
      *
-     * @param array $classes Array of classes to append to body tag.
-     * @return array $classes
+     * @param string[] $classes Array of classes to append to body tag.
+     * @return string[]
      */
     public function add_nojs_body_class( $classes ) {
-        if ( ! in_array( 'no-js', $classes ) )
-            $classes[] = 'no-js';
+        /** This filter is documented in bp-core/bp-core-dependency.php */
+        if ( ! is_buddypress() || apply_filters( 'bp_enqueue_assets_in_bp_pages_only', true ) ) {
+            return $classes;
+        }
+
+        $classes[] = 'no-js';
 
         return array_unique( $classes );
@@ -493 +494 @@
      * @since 1.7.0
      */
-    public function localize_scripts() {
-    }
+    public function localize_scripts() {}
 
     /**

branches/14.0/src/bp-templates/bp-nouveau/buddypress-functions.php

@@ -224 +224 @@
         remove_action( 'bp_enqueue_community_scripts', 'bp_core_confirmation_js' );
 
-        /** This filter is documented in bp-core/bp-core-dependency.php */
-        if ( is_buddypress() || ! apply_filters( 'bp_enqueue_assets_in_bp_pages_only', true ) ) {
-            // Body no-js class.
-            add_filter( 'body_class', array( $this, 'add_nojs_body_class' ), 20, 1 );
-        }
+        // Body no-js class.
+        add_filter( 'body_class', array( $this, 'add_nojs_body_class' ), 20, 1 );
 
         // Ajax querystring.
@@ -475 +472 @@
      * @since 3.0.0
      *
-     * @param array $classes Array of classes to append to body tag.
-     *
-     * @return array $classes
+     * @param string[] $classes Array of classes to append to body tag.
+     * @return string[]
      */
     public function add_nojs_body_class( $classes ) {
+        /** This filter is documented in bp-core/bp-core-dependency.php */
+        if ( ! is_buddypress() || apply_filters( 'bp_enqueue_assets_in_bp_pages_only', true ) ) {
+            return $classes;
+        }
+
         $classes[] = 'no-js';
+
         return array_unique( $classes );
     }