Changeset 14173

Timestamp:

12/26/2025 07:26:02 PM (5 weeks ago)

Author:

espellcaste

Message:

Deprecate the current CSS class for the group item since it is too generic.

We also introduce a prefixed bp-group-status-{status} class (e.g., bp-group-status-hidden) while keeping the old non-prefixed class for backwards compatibility.

The old, non-prefixed, class will be properly removed in the next release (see #9316).

Props t.schwarz, dcavins, noruzzaman, and vapvarun.

Fixes #9308 (trunk)

File:

• trunk/src/bp-groups/bp-groups-template.php (modified) (5 diffs)

trunk/src/bp-groups/bp-groups-template.php

@@ -671 +671 @@
      *
      * @param false|int|string|BP_Groups_Group $group (Optional) The Group ID, the Group Slug or the Group object.
-     *                                   Default: false.
+     *                                                Default: false.
      * @return int
      */
@@ -698 +698 @@
  * @since 1.7.0
  *
- * @param array $classes Array of custom classes.
+ * @param string[] $classes Array of custom classes.
  */
 function bp_group_class( $classes = array() ) {
@@ -711 +711 @@
      * @global BP_Groups_Template $groups_template The Groups template loop class.
      *
-     * @param array $classes Array of custom classes.
+     * @param string[] $classes Array of custom classes.
      * @return string Row class of the group.
      */
@@ -727 +727 @@
         }
 
-        // Group type - public, private, hidden.
-        $classes[] = sanitize_key( $groups_template->group->status );
+        // Possible values include: public, private, hidden, etc.
+        $group_status = sanitize_key( $groups_template->group->status );
+        $classes[]    = 'bp-group-status-' . $group_status;
+
+        /**
+         * Will be removed in a future release.
+         *
+         * @deprecated Use the `bp-group-status-{status}` class instead.
+         *
+         * @see https://buddypress.trac.wordpress.org/ticket/9316
+         */
+        $classes[] = $group_status;
 
         // Add current group types.
-        if ( $group_types = bp_groups_get_group_type( bp_get_group_id(), false ) ) {
+        $group_types = bp_groups_get_group_type( bp_get_group_id(), false );
+        if ( is_array( $group_types ) ) {
             foreach ( $group_types as $group_type ) {
                 $classes[] = sprintf( 'group-type-%s', esc_attr( $group_type ) );
@@ -768 +779 @@
          * @since 1.7.0
          *
-         * @param array $classes Array of determined classes for the row.
-         */
-        $classes = array_map( 'sanitize_html_class', apply_filters( 'bp_get_group_class', $classes ) );
+         * @param string[] $classes Array of determined classes for the row.
+         */
+        $classes = apply_filters( 'bp_get_group_class', $classes );
+
+        $classes = array_map( 'sanitize_html_class', $classes );
         $classes = array_merge( $classes, array() );
-        $retval = 'class="' . join( ' ', $classes ) . '"';
-
-        return $retval;
+
+        return 'class="' . join( ' ', $classes ) . '"';
     }