04:09 <_aj_> hmm, estimatesmartfee 10 conservative --> 267sat/vb ; 10 economical --> 51sat/vb ; mempool.space low/med/high pri --> 42/45/48 sat/vb. should we think about changing the default to economical?

05:35 <bitcoin-git> [bitcoin] maflcko closed pull request #28169: script: throw disabled err for op_ver and its variants (master...script/check-op-verif) https://github.com/bitcoin/bitcoin/pull/28169

06:35 <bitcoin-git> [bitcoin] maflcko opened pull request #29967: test: Add two more urlDecode tests (master...2404-test-urlDec-) https://github.com/bitcoin/bitcoin/pull/29967

08:18 <bitcoin-git> [bitcoin] maflcko opened pull request #29968: refactor: Avoid unused-variable warning in init.cpp (master...2404-init-) https://github.com/bitcoin/bitcoin/pull/29968

08:40 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2eff198f4900...7973a6709156

08:40 <bitcoin-git> bitcoin/master fa55972 MarcoFalke: test: Add two more urlDecode tests

08:40 <bitcoin-git> bitcoin/master 7973a67 merge-script: Merge bitcoin/bitcoin#29967: test: Add two more urlDecode tests

08:40 <bitcoin-git> [bitcoin] fanquake merged pull request #29967: test: Add two more urlDecode tests (master...2404-test-urlDec-) https://github.com/bitcoin/bitcoin/pull/29967

09:16 <vasild> brunoerg: lightlike: yeah, could be. Maybe it should try more aggressive. What I observe now is that currently my node has 0 outbound i2p connections. Last i2p outbound was established 2 hours ago, it is apparenly disconnected now but I do not know when it was disconnected. Was it disconnected like 1h50min ago or 5min ago? In those 2 hours there are 11 attempts to connect to i2p peers, all failed

09:17 <vasild> our logging is not symmetric - we log when a new peer is connected, but not when disconnected (assuming -debug=net is not enabled)

09:19 <vasild> Maybe the disconnect message https://github.com/bitcoin/bitcoin/blob/7973a670915632b75a6aa16f24f98b936865c48f/src/net_processing.cpp#L1708 should have the same category/severity as the connect message: https://github.com/bitcoin/bitcoin/blob/7973a670915632b75a6aa16f24f98b936865c48f/src/net_processing.cpp#L3707

10:17 <hebasto> luke-jr: people on Transifex.com are not happy with add Knots resources to translate. A quote from their complains: "If the bitcoin-knots ressources are supposed to belong the a forked project of bitcoin-core (bitcoin-knots), i would prefer a new project being setup here on Transifex, since its kinda hijacking the main bitcoin core project and binding translation effort from members who want to support the bitcoin core

10:17 <hebasto> project from my impression."

10:18 <hebasto> s/add/added/

10:21 <hebasto> laanwj: ^ what do you think?

10:50 <laanwj> @hebasto i tend to agree with them, i don't understand the reasoning why it came this way in the first place, why isn't there a seperate transifex project for knots?

10:50 <laanwj> as i see it this just complicated stuff for us, and for translators

10:51 <hebasto> luke-jr: please remove Knots resource file from the Bitcoin Core project on Transifex.com

12:23 <bitcoin-git> [bitcoin] iw4p opened pull request #29969: refactor: convert string formatting to F-strings (master...enhancement/f-string-formatting) https://github.com/bitcoin/bitcoin/pull/29969

12:24 <bitcoin-git> [bitcoin] iw4p opened pull request #29970: refactor: switch from curl to requests for HTTP requests (master...feature/requests-library-usage) https://github.com/bitcoin/bitcoin/pull/29970

12:25 <bitcoin-git> [bitcoin] iw4p opened pull request #29971: refactor: refactored platform assignment into get_platform function (master...fix/platform-consistency) https://github.com/bitcoin/bitcoin/pull/29971

13:26 <laanwj> TIL a linker map is actually much more useful to compare guix binaries than whatever the hell i was doing with parsing DWARF information

13:26 <laanwj> it literally tells where each part of the binary came from

13:35 <bitcoin-git> [bitcoin] alfonsoromanz opened pull request #29973: [Test] Assumeutxo: ensure failure when importing a snapshot twice (master...assumeutxo-test-import-snapshot-twice) https://github.com/bitcoin/bitcoin/pull/29973

16:12 <vasild> laanwj: I dunno about thread-local in FreeBSD. I could perform some tests. How exactly is it (was) broken? Let me try to dig some more info...

16:15 <laanwj> i'm not sure whether it didn't work or didn't compile, it was a long time ago

16:16 <laanwj> i think it's a good thing to reconsider these kind of workarounds once in a while 😄

16:19 <laanwj> but yes running some basic tests should be enough, eg compiling and running bitcoind with thread local support (ir uses it for some logging stuff IIRC)

16:49 <laanwj> tbh i would be surprised if the BSDs don't have that in order yet, less certain about mingw

18:21 <lightlike> vasild: yes, that might be helpful. we only log new outbound connections unconditionally, so the disconnect log would need to make that distinction too to prevent log spamming by inbounds.

18:46 <bitcoin-git> [bitcoin] sr-gi opened pull request #29974: fuzz: txorphan tests fixups (master...2024-04-txorphan-fuzz) https://github.com/bitcoin/bitcoin/pull/29974

20:07 <bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7973a6709156...1ffbd9634982

20:07 <bitcoin-git> bitcoin/master f19f0a2 tdb3: test: Run framework unit tests in parallel

20:07 <bitcoin-git> bitcoin/master 1ffbd96 Ava Chow: Merge bitcoin/bitcoin#29771: test: Run framework unit tests in parallel

20:07 <bitcoin-git> [bitcoin] achow101 merged pull request #29771: test: Run framework unit tests in parallel (master...parallel_unit_tests) https://github.com/bitcoin/bitcoin/pull/29771

21:30 <bitcoin-git> [bitcoin] mzumsande opened pull request #29975: blockstorage: Separate reindexing from saving new blocks (master...202404_blockstorage_split_reindex) https://github.com/bitcoin/bitcoin/pull/29975

21:57 <bitcoin-git> [bitcoin] hebasto opened pull request #29976: build, msvc: Drop duplicated `common\url.cpp` source file (master...240426-msvc-url) https://github.com/bitcoin/bitcoin/pull/29976